Commit graph

139 commits

Author SHA1 Message Date
David Sinclair
fff85beb23 iOS: fixed #960 (returning on iPad reloads story)
A bit tricksy to track down, but videos keep playing and the scroll
position is preserved (on rotation while in the app, too).
2016-11-01 15:10:56 -07:00
David Sinclair
27fbf12081 iOS: fixed #929 (rotation issue on iPhone with Safari browser)
This was a curly one!  I also fixed a bunch of Xcode 8 warnings (for
non-third-party code; I'd like to fix the third-party ones to get to
zero warnings, but don't know how you feel about that).
2016-10-05 21:03:32 -07:00
Nicholas Riley
a529f340c6 Fix stories intermittently not displaying; clean up story loading.
Funnel all HTML loading through -loadHTMLString:.

Cache base URL (which is always the same) in a static variable instead of computing it different ways and putting in an instance variable temporarily.

Use more intention-revealing variable names.

Only set hasStory when we’re actually loading the story itself.

Only set the font size and line spacing once, in webViewDidStartLoad, because the DOM is always set up by then in my experience.

Only bother to set font size and line spacing if we’re loading a (full) story.

Show the Web view when a full story *starts* to load, as sometimes it may not complete but you still want to see a partially loaded story.  (Fixes an intermittent issue with AnandTech; see https://getsatisfaction.com/newsblur/topics/anandtech-straight-up-doesnt-load-on-the-ios-app)
2016-08-23 20:52:34 -04:00
Samuel Clay
839f5089eb Commenting 2016-08-10 13:26:52 -07:00
David Sinclair
6da7d4ce6b iOS: white flash fix 2016-06-15 21:32:59 -07:00
Samuel Clay
612caca806 Fixing iPad Pro image sizings. Screenshots for v6.0. Build 62. The iOS app v6.0 is now uploaded and awaiting approval. 2016-04-06 18:14:06 -07:00
Samuel Clay
1b4e5a8561 Fixing story author on newsletters 2016-03-07 22:46:34 -08:00
Samuel Clay
6a98241f88 Themed disclosure buttons for folder titles. 2016-02-27 13:20:32 -08:00
Samuel Clay
33f8beabfc Cleaning up story detail samples. Cleaning up comment borders and margins. 2016-02-06 14:40:07 -08:00
Samuel Clay
17dba6d975 Styling sepia story detail. 2016-02-06 14:06:50 -08:00
David Sinclair
8bb54a1e83 iOS: two-stage story loading
Works much better.
2016-02-05 12:19:48 -08:00
David Sinclair
e98cf18bfd iOS: reverted WKWebView changes
I kept a copy of the files from before the change, just in case, so I
just copied them back in to revert everything.
2016-02-01 10:44:59 -08:00
David Sinclair
a14ae1ba87 iOS: switched story view to WKWebView
This should have significant performance improvements, leveraging the
full power of the Safari Nitro Javascript engine and out-of-process
rendering. Also as requested, it now observes the progress and removes
the spinner as soon as the base HTML has loaded.  Some big changes, but
doesn’t look like anything is broken.
2016-01-30 20:54:53 -08:00
David Sinclair
c8d22f4594 iOS: done #813 (custom domain) 2016-01-21 22:11:37 -08:00
Samuel Clay
aaf6a164c5 Fixing share bar alignment issue that cropped up in 689c468 (as a result of @mihaip's 2cf5ec83da). 2016-01-21 14:01:25 -08:00
David Sinclair
689c468563 iOS: fixed share bar alignment issue 2016-01-08 17:21:59 -08:00
David Sinclair
df6b098664 iOS: tweaked #825 (themes) 2016-01-07 21:12:58 -08:00
David Sinclair
d017a595ac Merge branch 'master' into 5.1 2015-12-21 19:35:57 -08:00
Mihai Parparita
2cf5ec83da Use standard mode in the story detail web view.
It missing a doc type, which was resulting in quirks mode being used. This
affects font-size inheritance in tables and other behaviors.
2015-12-21 11:39:39 -08:00
David Sinclair
8ad5b8b602 iOS: tweaked #825 (dark mode)
More tweaks to the theme handling, including the story CSS. The gesture
has been extended to make it easier to switch themes: it's still up for
light and down for dark (like a light switch), but swiping up again
will switch between the two light themes, and swiping down again will
switch between the two dark themes.
2015-12-20 22:04:55 -08:00
David Sinclair
07e667a95d iOS: tweaked #825 (dark mode)
Eliminated the old WYPopoverController from the code, since it isn’t
needed and isn’t compatible with theming.  All popovers now use the
modern UIPopoverPresentationController mechanism.
2015-12-15 12:37:18 -08:00
David Sinclair
746a2f76ea iOS: tweaked #825 (dark mode)
Fix for @nriley’s reported issue of Tap on a story > Go back to the
story list > Tap on the next story on iPhone.
2015-12-12 15:42:39 -08:00
David Sinclair
d381f59154 NewsBlur: tweaked #825 (dark mode)
Fix for about:blank flashing.
2015-12-10 15:07:25 -08:00
Nicholas Riley
52cfb516f0 iOS: Only display/respond to valid keyboard shortcuts (#826). 2015-12-09 11:20:35 -05:00
Nicholas Riley
b88e1cc5fc First pass at iOS keyboard support (#826). 2015-12-09 11:19:13 -05:00
Nicholas Riley
3e39a47de5 Merge branch 'master' into 5.1 2015-12-09 10:49:26 -05:00
David Sinclair
af2ab36297 iOS: done #825 (dark mode) 2015-12-07 16:09:49 -08:00
Samuel Clay
d694993d8d V5.0.2. 2015-12-01 16:51:18 -08:00
Samuel Clay
0117bbc815 No longer clearing story when opening original view. Also fixing rotation issues when returning to story detail from rotated original view. 2015-11-30 18:12:10 -08:00
David Sinclair
05995eff64 iOS: done #820 (improve split view support) 2015-11-28 22:07:38 -08:00
Samuel Clay
0d7c3a3528 Fixing #827 - double tapping was disabling scrolling but not turning it back on. This is in response to the fix #786. 2015-11-23 11:14:03 -08:00
David Sinclair
195e38c329 iOS: fixed #786 (scroll on double-tap) 2015-11-12 15:30:43 -08:00
David Sinclair
2892edcca1 iOS: fixed #802 (link causes scroll to top) 2015-11-05 14:16:11 -08:00
David Sinclair
d2096ff0dc iOS: tweaked #791 (more fonts)
Fixed initial display of the bundled font, and improved the code to
make it easier to add others.
2015-11-03 12:10:28 -08:00
David Sinclair
17bd8ad676 iOS: tweaked #791 (more fonts)
Now uses the OregonLDO font.
2015-11-02 22:17:06 -08:00
David Sinclair
d8f79528dd iOS: done #735 (non-modal story notifications) 2015-10-28 21:50:23 -07:00
David Sinclair
2ce271e664 iOS: fixed #779 (selected text glitch)
Easier than expected; just needed to detect when it's been blanked and
force a redraw.  Makes loading a different story tidier, too.
2015-10-27 21:52:11 -07:00
David Sinclair
fbd8d62be1 Fixed #772 (story traversal buttons misaligned) 2015-10-24 20:58:00 -07:00
Samuel Clay
8c26fb1117 Aww yeah, fixing race condition for drawing stories. 2015-10-06 18:52:58 -07:00
Samuel Clay
b1d9cc9e92 Correctly showing text or story view for stories based on story feed, not folder. 2015-10-05 11:45:40 -07:00
Samuel Clay
9806ed08f1 Experimental commit to speedup scrolling between stories. 2015-10-05 11:45:40 -07:00
Samuel Clay
e780cb0213 Logging view will layout subviews to figure out the off-page rotation issue. 2015-09-28 20:24:05 -07:00
Samuel Clay
41d0423c5b Fixing rotation losing scroll position. Still have font size issue when returning to view with different rotation. 2015-09-28 20:01:17 -07:00
Samuel Clay
b838723449 Fixing rotation bugs for the most part. 2015-09-23 14:37:54 -07:00
Samuel Clay
2829565167 Rewriting story page control to use autolayout. 2015-09-23 13:02:25 -07:00
Samuel Clay
b35ad92e98 Fixing rotation bugs around minimum scale. 2015-09-23 11:34:03 -07:00
Samuel Clay
3ec1549c57 Fixing traverse view movements. 2015-09-22 18:20:48 -07:00
Samuel Clay
6556898be4 Attempting a fix for parent view controller orientation on rotation. Also fixing Text view causing active story position to be accidentally shifted. 2015-09-22 17:16:08 -07:00
Samuel Clay
fa19220c66 Adding crashalytics. Refactoring some rotation methods. 2015-09-22 16:34:24 -07:00
Samuel Clay
c5de98447f Cleaning up unused rotation code. 2015-09-22 13:30:21 -07:00