This was a curly one! I also fixed a bunch of Xcode 8 warnings (for
non-third-party code; I'd like to fix the third-party ones to get to
zero warnings, but don't know how you feel about that).
Don’t try to subclass UIActivityItemProvider as well as implement UIActivityItemSource - the latter is better suited for what NewsBlur wants to do (provide different items based on activity type).
Provide the URL as a separate item where possible; only return strings from UIActivityItemSource.
Crashed due to the -addKeyCommand: method not being available before
iOS 9. @nriley may want to implement some alternative solution (e.g.
overriding the -keyCommands method), but this fixes the crash.
Use the same popover creation code in more places, which adds Escape and
Command-. to dismiss popovers.
Ensure that popovers both get and can accept first responder, preventing
keyboard input from leaking through to an underlying view controller.
Without this, it can be confusing as, for example, you can navigate to a
different story while you’ve got a ‘mark read’ popover shown for another
story.
Now using the streamlined move menu to move sites & folders via the
feed detail menu, and the delete & mute site functions behave
similarly, more like the website (no more ugly alerts!).
Added a new “Ask” item to the Long Press Story Title preferences.
Chosen by default.
When “Ask” is selected, the feed detail long press displays a menu with
mark read options and other long press options.
Also makes them continue to work when you change the bundle identifier (necessary if you want to keep a self-compiled version of NewsBlur at the same time as the official version).
Eliminated the old WYPopoverController from the code, since it isn’t
needed and isn’t compatible with theming. All popovers now use the
modern UIPopoverPresentationController mechanism.
Also remove -[NBContainerViewController showSendToController:] which no longer does anything of the sort, and attempt to speed up popover-popover transition a bit by not animating.
Only the older/newer long-press one; still have the story image one,
but I think that’s okay as-is since it has a title/alt text display.
Also removed some redundant code.
