From d18216e49db740027193e9c5b69469cbf874151b Mon Sep 17 00:00:00 2001 From: Samuel Clay Date: Thu, 17 Dec 2020 18:09:38 -0500 Subject: [PATCH] Adding more logging around real-time updates to debug dashboard swallowing story updates. --- media/js/newsblur/reader/reader.js | 2 +- node/unread_counts.coffee | 10 +++++----- node/unread_counts.js | 11 ++++++----- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/media/js/newsblur/reader/reader.js b/media/js/newsblur/reader/reader.js index f0b5a0805..f7d51ae16 100644 --- a/media/js/newsblur/reader/reader.js +++ b/media/js/newsblur/reader/reader.js @@ -5088,7 +5088,7 @@ this.socket.on('feed:story:new', _.bind(function(feed_id, message) { var story_hash = message.split(',')[0]; var timestamp = message.split(',')[1]; - // NEWSBLUR.log(['Real-time new story', feed_id, story_hash, timestamp]); + NEWSBLUR.log(['Real-time new story', feed_id, story_hash, timestamp, message]); if (NEWSBLUR.app.dashboard_rivers) { NEWSBLUR.app.dashboard_rivers.map(function (r) { r.new_story(story_hash, timestamp); }); } diff --git a/node/unread_counts.coffee b/node/unread_counts.coffee index 64e83939c..309bb416b 100644 --- a/node/unread_counts.coffee +++ b/node/unread_counts.coffee @@ -78,13 +78,13 @@ io.on 'connection', (socket) -> socket.subscribe.subscribe @username socket.subscribe.on 'message', (channel, message) => - log.info @username, "Update on #{channel}: #{message}" + event_name = 'feed:update' if channel == @username - socket.emit 'user:update', channel, message + event_name = 'user:update' else if channel.indexOf(':story') >= 0 - socket.emit 'feed:story:new', channel, message - else - socket.emit 'feed:update', channel, message + event_name = 'feed:story:new' + log.info @username, "Update on #{channel}: #{event_name} - #{message}" + socket.emit event_name, channel, message socket.on 'disconnect', () => socket.subscribe?.quit() diff --git a/node/unread_counts.js b/node/unread_counts.js index d5201c88e..c65a16876 100644 --- a/node/unread_counts.js +++ b/node/unread_counts.js @@ -98,14 +98,15 @@ return socket.subscribe.subscribe(this.username); }); return socket.subscribe.on('message', (channel, message) => { - log.info(this.username, `Update on ${channel}: ${message}`); + var event_name; + event_name = 'feed:update'; if (channel === this.username) { - return socket.emit('user:update', channel, message); + event_name = 'user:update'; } else if (channel.indexOf(':story') >= 0) { - return socket.emit('feed:story:new', channel, message); - } else { - return socket.emit('feed:update', channel, message); + event_name = 'feed:story:new'; } + log.info(this.username, `Update on ${channel}: ${event_name} - ${message}`); + return socket.emit(event_name, channel, message); }); }); return socket.on('disconnect', () => {