From cf6b9b8cb1588828c44b13fcf676e1a7f9b8a013 Mon Sep 17 00:00:00 2001 From: Samuel Clay Date: Thu, 12 Sep 2013 17:34:44 -0700 Subject: [PATCH] Fixing 2 ios crashes: double-tapping instapaper button and a weird keyboard condition. --- clients/ios/Classes/UIActivitiesControl.m | 9 ++++----- .../Classes/RWInstapaperActivityRequest.m | 9 ++++++--- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/clients/ios/Classes/UIActivitiesControl.m b/clients/ios/Classes/UIActivitiesControl.m index 367bebf97..9e2f32425 100644 --- a/clients/ios/Classes/UIActivitiesControl.m +++ b/clients/ios/Classes/UIActivitiesControl.m @@ -67,13 +67,12 @@ applicationActivities:appActivities]; [shareSheet setValue:[appDelegate.activeStory objectForKey:@"story_title"] forKey:@"subject"]; - [shareSheet setCompletionHandler:^(NSString *activityType, BOOL completed) { if (completed) { - [[NSNotificationCenter defaultCenter] addObserver:self - selector:@selector(keyboardDidHide:) - name:UIKeyboardDidHideNotification - object:nil]; +// [[NSNotificationCenter defaultCenter] addObserver:self +// selector:@selector(keyboardDidHide:) +// name:UIKeyboardDidHideNotification +// object:nil]; NSString *_completedString; if ([activityType isEqualToString:UIActivityTypePostToTwitter]) { diff --git a/clients/ios/Other Sources/InstapaperActivity/Classes/RWInstapaperActivityRequest.m b/clients/ios/Other Sources/InstapaperActivity/Classes/RWInstapaperActivityRequest.m index 963e3db3d..efd266ed3 100755 --- a/clients/ios/Other Sources/InstapaperActivity/Classes/RWInstapaperActivityRequest.m +++ b/clients/ios/Other Sources/InstapaperActivity/Classes/RWInstapaperActivityRequest.m @@ -111,11 +111,14 @@ self.connection = nil; if ([responseString compare:RESPONSE_SUCCESS] == NSOrderedSame) { - [self.delegate instapaperAddRequestSucceded:self]; + if ([self.delegate respondsToSelector:@selector(instapaperAddRequestSucceded:)]) + [self.delegate instapaperAddRequestSucceded:self]; } else if ([responseString compare:RESPONSE_PASSWORD_INCORRECT] == NSOrderedSame) { - [self.delegate instapaperAddRequestIncorrectPassword:self]; + if ([self.delegate respondsToSelector:@selector(instapaperAddRequestIncorrectPassword:)]) + [self.delegate instapaperAddRequestIncorrectPassword:self]; } else { - [self.delegate instapaperAddRequestFailed:self]; + if ([self.delegate respondsToSelector:@selector(instapaperAddRequestFailed:)]) + [self.delegate instapaperAddRequestFailed:self]; } }