From 6cf636271dbe64ee26ec70a65fa75097886fb309 Mon Sep 17 00:00:00 2001 From: sictiru Date: Mon, 9 Nov 2020 18:35:28 -0800 Subject: [PATCH 01/26] #1381 Support Action Bar and AndroidX Alert Dialog --- clients/android/NewsBlur/build.gradle | 4 +++- .../android/NewsBlur/res/layout/activity_addfeedexternal.xml | 2 +- clients/android/NewsBlur/res/layout/activity_itemslist.xml | 2 +- clients/android/NewsBlur/res/layout/activity_profile.xml | 2 +- clients/android/NewsBlur/res/layout/fragment_itemgrid.xml | 2 +- .../android/NewsBlur/res/layout/fragment_profileactivity.xml | 2 +- .../android/NewsBlur/res/layout/fragment_profiledetails.xml | 2 +- clients/android/NewsBlur/res/layout/row_activity.xml | 2 +- clients/android/NewsBlur/res/layout/row_feedresult.xml | 2 +- clients/android/NewsBlur/res/values/attrs.xml | 2 +- clients/android/NewsBlur/res/values/colors.xml | 4 ++++ .../NewsBlur/src/com/newsblur/activity/AddFeedExternal.java | 2 +- .../NewsBlur/src/com/newsblur/activity/FeedChooser.java | 2 +- clients/android/NewsBlur/src/com/newsblur/activity/Main.java | 2 +- .../NewsBlur/src/com/newsblur/activity/MuteConfig.java | 2 +- .../NewsBlur/src/com/newsblur/activity/NbActivity.java | 4 +++- .../android/NewsBlur/src/com/newsblur/activity/Profile.java | 2 +- .../NewsBlur/src/com/newsblur/activity/SearchForFeeds.java | 2 +- .../android/NewsBlur/src/com/newsblur/activity/Settings.java | 5 +++-- .../NewsBlur/src/com/newsblur/fragment/AddFeedFragment.java | 2 +- .../src/com/newsblur/fragment/AlertDialogFragment.java | 3 ++- .../src/com/newsblur/fragment/ChooseFoldersFragment.java | 3 ++- .../src/com/newsblur/fragment/DeleteFeedFragment.java | 3 ++- .../src/com/newsblur/fragment/DeleteFolderFragment.java | 2 +- .../src/com/newsblur/fragment/EditReplyDialogFragment.java | 3 ++- .../src/com/newsblur/fragment/FeedIntelTrainerFragment.java | 3 ++- .../src/com/newsblur/fragment/LoginAsDialogFragment.java | 3 ++- .../src/com/newsblur/fragment/LogoutDialogFragment.java | 5 +++-- .../newsblur/fragment/ReadingActionConfirmationFragment.java | 3 ++- .../src/com/newsblur/fragment/ReadingItemFragment.java | 2 +- .../src/com/newsblur/fragment/RenameDialogFragment.java | 2 +- .../src/com/newsblur/fragment/ReplyDialogFragment.java | 3 ++- .../src/com/newsblur/fragment/SaveSearchFragment.java | 2 +- .../src/com/newsblur/fragment/ShareDialogFragment.java | 3 ++- .../src/com/newsblur/fragment/StoryIntelTrainerFragment.java | 3 ++- 35 files changed, 56 insertions(+), 36 deletions(-) diff --git a/clients/android/NewsBlur/build.gradle b/clients/android/NewsBlur/build.gradle index bb48479f6..9fc990fd4 100644 --- a/clients/android/NewsBlur/build.gradle +++ b/clients/android/NewsBlur/build.gradle @@ -38,6 +38,7 @@ dependencies { implementation 'nl.dionsegijn:konfetti:1.2.2' implementation 'com.github.jinatonic.confetti:confetti:1.1.2' implementation 'com.google.android.play:core:1.8.3' + implementation "com.google.android.material:material:1.2.1" } android { @@ -47,13 +48,14 @@ android { minSdkVersion 21 targetSdkVersion 29 versionCode 175 - versionName "10.1b7" + versionName "10.1dev" } compileOptions.with { sourceCompatibility = JavaVersion.VERSION_1_8 targetCompatibility = JavaVersion.VERSION_1_8 } android.buildFeatures.viewBinding = true + android.buildFeatures.dataBinding = true sourceSets { main { diff --git a/clients/android/NewsBlur/res/layout/activity_addfeedexternal.xml b/clients/android/NewsBlur/res/layout/activity_addfeedexternal.xml index 2e9d1b4ba..ecbe55a74 100644 --- a/clients/android/NewsBlur/res/layout/activity_addfeedexternal.xml +++ b/clients/android/NewsBlur/res/layout/activity_addfeedexternal.xml @@ -3,7 +3,7 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:animateLayoutChanges="true" - style="?itemBackground" > + style="?layoutBackground" > + style="?layoutBackground" > + style="?layoutBackground" > diff --git a/clients/android/NewsBlur/res/layout/row_feedresult.xml b/clients/android/NewsBlur/res/layout/row_feedresult.xml index 5a73a952d..e05228b2a 100644 --- a/clients/android/NewsBlur/res/layout/row_feedresult.xml +++ b/clients/android/NewsBlur/res/layout/row_feedresult.xml @@ -2,7 +2,7 @@ - + diff --git a/clients/android/NewsBlur/res/values/colors.xml b/clients/android/NewsBlur/res/values/colors.xml index ae2eb19cf..cc5cdf86c 100644 --- a/clients/android/NewsBlur/res/values/colors.xml +++ b/clients/android/NewsBlur/res/values/colors.xml @@ -1,6 +1,10 @@ + @color/nb_green_gray91 + @color/black + @color/newsblur_blue + #000000 #121212 #1A1A1A diff --git a/clients/android/NewsBlur/src/com/newsblur/activity/AddFeedExternal.java b/clients/android/NewsBlur/src/com/newsblur/activity/AddFeedExternal.java index bc044410c..ca2cfcd1f 100644 --- a/clients/android/NewsBlur/src/com/newsblur/activity/AddFeedExternal.java +++ b/clients/android/NewsBlur/src/com/newsblur/activity/AddFeedExternal.java @@ -20,7 +20,7 @@ public class AddFeedExternal extends NbActivity implements AddFeedFragment.AddFe protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); binding = ActivityAddfeedexternalBinding.inflate(getLayoutInflater()); - getActionBar().setDisplayHomeAsUpEnabled(true); + getSupportActionBar().setDisplayHomeAsUpEnabled(true); setContentView(binding.getRoot()); diff --git a/clients/android/NewsBlur/src/com/newsblur/activity/FeedChooser.java b/clients/android/NewsBlur/src/com/newsblur/activity/FeedChooser.java index 9698fc645..90d95d06a 100644 --- a/clients/android/NewsBlur/src/com/newsblur/activity/FeedChooser.java +++ b/clients/android/NewsBlur/src/com/newsblur/activity/FeedChooser.java @@ -46,7 +46,7 @@ abstract public class FeedChooser extends NbActivity { protected void onCreate(@Nullable Bundle savedInstanceState) { super.onCreate(savedInstanceState); bindLayout(); - getActionBar().setDisplayHomeAsUpEnabled(true); + getSupportActionBar().setDisplayHomeAsUpEnabled(true); setupList(); loadFeeds(); loadFolders(); diff --git a/clients/android/NewsBlur/src/com/newsblur/activity/Main.java b/clients/android/NewsBlur/src/com/newsblur/activity/Main.java index a48d479fb..bf4074de8 100644 --- a/clients/android/NewsBlur/src/com/newsblur/activity/Main.java +++ b/clients/android/NewsBlur/src/com/newsblur/activity/Main.java @@ -58,7 +58,7 @@ public class Main extends NbActivity implements StateChangedListener, SwipeRefre binding = ActivityMainBinding.inflate(getLayoutInflater()); setContentView(binding.getRoot()); - getActionBar().hide(); + getSupportActionBar().hide(); // set the status bar to an generic loading message when the activity is first created so // that something is displayed while the service warms up diff --git a/clients/android/NewsBlur/src/com/newsblur/activity/MuteConfig.java b/clients/android/NewsBlur/src/com/newsblur/activity/MuteConfig.java index 9c767a531..aae67bb3d 100644 --- a/clients/android/NewsBlur/src/com/newsblur/activity/MuteConfig.java +++ b/clients/android/NewsBlur/src/com/newsblur/activity/MuteConfig.java @@ -1,6 +1,5 @@ package com.newsblur.activity; -import android.app.AlertDialog; import android.content.Intent; import android.database.Cursor; import android.text.TextUtils; @@ -10,6 +9,7 @@ import android.view.View; import android.view.ViewGroup; import android.widget.FrameLayout; +import androidx.appcompat.app.AlertDialog; import androidx.core.content.ContextCompat; import com.newsblur.R; diff --git a/clients/android/NewsBlur/src/com/newsblur/activity/NbActivity.java b/clients/android/NewsBlur/src/com/newsblur/activity/NbActivity.java index 42da9b5ba..7cf4c09fe 100644 --- a/clients/android/NewsBlur/src/com/newsblur/activity/NbActivity.java +++ b/clients/android/NewsBlur/src/com/newsblur/activity/NbActivity.java @@ -1,6 +1,8 @@ package com.newsblur.activity; import android.os.Bundle; + +import androidx.appcompat.app.AppCompatActivity; import androidx.fragment.app.FragmentActivity; import android.widget.Toast; @@ -15,7 +17,7 @@ import java.util.ArrayList; * The base class for all Activities in the NewsBlur app. Handles enforcement of * login state and tracking of sync/update broadcasts. */ -public class NbActivity extends FragmentActivity { +public class NbActivity extends AppCompatActivity { public static final int UPDATE_DB_READY = (1<<0); public static final int UPDATE_METADATA = (1<<1); diff --git a/clients/android/NewsBlur/src/com/newsblur/activity/Profile.java b/clients/android/NewsBlur/src/com/newsblur/activity/Profile.java index 9684aa983..671120465 100644 --- a/clients/android/NewsBlur/src/com/newsblur/activity/Profile.java +++ b/clients/android/NewsBlur/src/com/newsblur/activity/Profile.java @@ -28,7 +28,7 @@ public class Profile extends NbActivity { protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); setContentView(R.layout.activity_profile); - getActionBar().setDisplayHomeAsUpEnabled(true); + getSupportActionBar().setDisplayHomeAsUpEnabled(true); apiManager = new APIManager(this); if (savedInstanceState == null) { userId = getIntent().getStringExtra(USER_ID); diff --git a/clients/android/NewsBlur/src/com/newsblur/activity/SearchForFeeds.java b/clients/android/NewsBlur/src/com/newsblur/activity/SearchForFeeds.java index bd484072b..e8d4f6123 100644 --- a/clients/android/NewsBlur/src/com/newsblur/activity/SearchForFeeds.java +++ b/clients/android/NewsBlur/src/com/newsblur/activity/SearchForFeeds.java @@ -46,7 +46,7 @@ public class SearchForFeeds extends NbActivity implements LoaderCallbacks Date: Mon, 9 Nov 2020 21:37:29 -0800 Subject: [PATCH 02/26] #1381 Material Light Theme --- clients/android/NewsBlur/AndroidManifest.xml | 3 +- .../res/layout/actionbar_custom_icon.xml | 27 +++--- .../NewsBlur/res/layout/activity_main.xml | 10 +-- .../NewsBlur/res/layout/activity_reading.xml | 10 ++- .../NewsBlur/res/layout/dialog_trainstory.xml | 6 +- .../res/layout/fragment_readingitem.xml | 4 +- .../NewsBlur/res/layout/include_intel_row.xml | 6 +- .../layout/include_reading_item_comment.xml | 4 +- .../res/layout/infrequent_cutoff_dialog.xml | 86 ++++++++++++------- .../res/layout/row_widget_config_feed.xml | 4 +- .../android/NewsBlur/res/menu/itemslist.xml | 23 ++--- clients/android/NewsBlur/res/menu/main.xml | 29 ++++--- .../NewsBlur/res/menu/menu_feed_chooser.xml | 11 +-- clients/android/NewsBlur/res/menu/reading.xml | 5 +- clients/android/NewsBlur/res/menu/search.xml | 5 +- .../NewsBlur/res/menu/story_context.xml | 23 ++--- .../android/NewsBlur/res/values/styles.xml | 17 ++-- clients/android/NewsBlur/res/values/theme.xml | 22 +++-- .../newsblur/activity/AddFeedExternal.java | 2 +- .../activity/AllSharedStoriesItemsList.java | 2 +- .../activity/AllSharedStoriesReading.java | 2 +- .../activity/AllStoriesItemsList.java | 2 +- .../newsblur/activity/AllStoriesReading.java | 3 +- .../com/newsblur/activity/FeedChooser.java | 1 - .../com/newsblur/activity/FeedItemsList.java | 2 +- .../com/newsblur/activity/FeedReading.java | 2 +- .../newsblur/activity/FolderItemsList.java | 2 +- .../com/newsblur/activity/FolderReading.java | 2 +- .../GlobalSharedStoriesItemsList.java | 2 +- .../activity/GlobalSharedStoriesReading.java | 2 +- .../activity/InfrequentItemsList.java | 2 +- .../newsblur/activity/InfrequentReading.java | 2 +- .../src/com/newsblur/activity/MuteConfig.java | 1 + .../src/com/newsblur/activity/Premium.java | 2 +- .../activity/ReadStoriesItemsList.java | 2 +- .../newsblur/activity/ReadStoriesReading.java | 2 +- .../activity/SavedStoriesItemsList.java | 2 +- .../activity/SavedStoriesReading.java | 2 +- .../com/newsblur/activity/SearchForFeeds.java | 6 +- .../src/com/newsblur/activity/Settings.java | 3 +- .../activity/SocialFeedItemsList.java | 2 +- .../newsblur/activity/SocialFeedReading.java | 2 +- .../com/newsblur/activity/WidgetConfig.java | 2 + .../InfrequentCutoffDialogFragment.java | 3 +- .../src/com/newsblur/util/UIUtils.java | 43 ++++------ 45 files changed, 224 insertions(+), 171 deletions(-) diff --git a/clients/android/NewsBlur/AndroidManifest.xml b/clients/android/NewsBlur/AndroidManifest.xml index fc63f0059..a126cfd9e 100644 --- a/clients/android/NewsBlur/AndroidManifest.xml +++ b/clients/android/NewsBlur/AndroidManifest.xml @@ -134,7 +134,8 @@ + android:launchMode="singleTask" + android:label="@string/mute_sites"/> diff --git a/clients/android/NewsBlur/res/layout/actionbar_custom_icon.xml b/clients/android/NewsBlur/res/layout/actionbar_custom_icon.xml index bf777969e..bbd87d986 100644 --- a/clients/android/NewsBlur/res/layout/actionbar_custom_icon.xml +++ b/clients/android/NewsBlur/res/layout/actionbar_custom_icon.xml @@ -1,26 +1,33 @@ - + + + - + diff --git a/clients/android/NewsBlur/res/layout/activity_main.xml b/clients/android/NewsBlur/res/layout/activity_main.xml index d8b2d1a67..552b26b18 100644 --- a/clients/android/NewsBlur/res/layout/activity_main.xml +++ b/clients/android/NewsBlur/res/layout/activity_main.xml @@ -9,9 +9,9 @@ + android:background="?colorPrimary" > -