diff --git a/clients/android/NewsBlur/res/drawable/ic_mark_read.xml b/clients/android/NewsBlur/res/drawable/ic_mark_read.xml index 761b25f9d..a3326471c 100644 --- a/clients/android/NewsBlur/res/drawable/ic_mark_read.xml +++ b/clients/android/NewsBlur/res/drawable/ic_mark_read.xml @@ -1,6 +1,6 @@ + android:viewportWidth="24" + android:viewportHeight="24"> + android:pathData="M15.5,14h-0.79l-0.28,-0.27C15.41,12.59 16,11.11 16,9.5 16,5.91 13.09,3 9.5,3S3,5.91 3,9.5 5.91,16 9.5,16c1.61,0 3.09,-0.59 4.23,-1.57l0.27,0.28v0.79l5,4.99L20.49,19l-4.99,-5zM9.5,14C7.01,14 5,11.99 5,9.5S7.01,5 9.5,5 14,7.01 14,9.5 11.99,14 9.5,14z" /> diff --git a/clients/android/NewsBlur/res/layout/activity_itemslist.xml b/clients/android/NewsBlur/res/layout/activity_itemslist.xml index 5b76c08f9..21f37af79 100644 --- a/clients/android/NewsBlur/res/layout/activity_itemslist.xml +++ b/clients/android/NewsBlur/res/layout/activity_itemslist.xml @@ -19,12 +19,13 @@ android:layout_height="wrap_content" android:layout_alignParentTop="true" android:animateLayoutChanges="true" - android:drawableLeft="@android:drawable/ic_menu_search" + android:drawableLeft="@drawable/ic_search" android:hint="@string/story_search_hint" android:imeOptions="actionSearch" android:inputType="textNoSuggestions" android:textSize="16sp" - android:visibility="gone" /> + android:visibility="gone" + android:autofillHints="@null"/> + app:chipSpacingHorizontal="8dp" + app:chipSpacingVertical="6dp" /> + app:chipSpacingHorizontal="8dp" + app:chipSpacingVertical="6dp" /> diff --git a/clients/android/NewsBlur/res/layout/reading_item_actions.xml b/clients/android/NewsBlur/res/layout/reading_item_actions.xml index b0335121e..b2a4e354b 100644 --- a/clients/android/NewsBlur/res/layout/reading_item_actions.xml +++ b/clients/android/NewsBlur/res/layout/reading_item_actions.xml @@ -30,25 +30,25 @@ app:icon="@drawable/ic_feed_train" /> + android:text="@string/save_this" + app:icon="@drawable/ic_saved" /> + android:text="@string/share_this" + app:icon="@drawable/ic_share"/> diff --git a/clients/android/NewsBlur/res/layout/row_saved_searches.xml b/clients/android/NewsBlur/res/layout/row_saved_searches.xml index 05f85c20d..1bc3883e4 100644 --- a/clients/android/NewsBlur/res/layout/row_saved_searches.xml +++ b/clients/android/NewsBlur/res/layout/row_saved_searches.xml @@ -6,8 +6,8 @@ @@ -120,8 +119,6 @@ android:layout_toLeftOf="@id/story_item_thumbnail_right" android:layout_toRightOf="@id/story_item_inteldot_container" android:layout_below="@id/story_item_title" - android:paddingRight="4dp" - android:maxLines="2" android:ellipsize="end" android:lineSpacingExtra="1dp" style="?storySnippetText" /> diff --git a/clients/android/NewsBlur/src/com/newsblur/activity/ItemsList.java b/clients/android/NewsBlur/src/com/newsblur/activity/ItemsList.java index 5a289b3f4..02f229c58 100644 --- a/clients/android/NewsBlur/src/com/newsblur/activity/ItemsList.java +++ b/clients/android/NewsBlur/src/com/newsblur/activity/ItemsList.java @@ -287,7 +287,7 @@ public abstract class ItemsList extends NbActivity { menu.findItem(R.id.menu_story_thumbnail_right_small).setChecked(true); } else if (thumbnailStyle == ThumbnailStyle.RIGHT_LARGE) { menu.findItem(R.id.menu_story_thumbnail_right_large).setChecked(true); - } else if (thumbnailStyle == ThumbnailStyle.OFF) { + } else if (thumbnailStyle.isOff()) { menu.findItem(R.id.menu_story_thumbnail_no_preview).setChecked(true); } diff --git a/clients/android/NewsBlur/src/com/newsblur/database/StoryViewAdapter.java b/clients/android/NewsBlur/src/com/newsblur/database/StoryViewAdapter.java index a0b46da30..537066789 100644 --- a/clients/android/NewsBlur/src/com/newsblur/database/StoryViewAdapter.java +++ b/clients/android/NewsBlur/src/com/newsblur/database/StoryViewAdapter.java @@ -624,8 +624,9 @@ public class StoryViewAdapter extends RecyclerView.Adapter UIUtils.dp2px(context, 11) COMPACT -> UIUtils.dp2px(context, 3) } + + fun getStoryContentRightPadding(context: Context, thumbnailStyle: ThumbnailStyle): Int = + if (thumbnailStyle.isRight()) UIUtils.dp2px(context, 4) + else UIUtils.dp2px(context, 16) } \ No newline at end of file diff --git a/clients/android/NewsBlur/src/com/newsblur/util/ThumbnailStyle.java b/clients/android/NewsBlur/src/com/newsblur/util/ThumbnailStyle.java deleted file mode 100644 index eddbd3d54..000000000 --- a/clients/android/NewsBlur/src/com/newsblur/util/ThumbnailStyle.java +++ /dev/null @@ -1,10 +0,0 @@ -package com.newsblur.util; - -public enum ThumbnailStyle { - LEFT_SMALL, - LEFT_LARGE, - RIGHT_SMALL, - RIGHT_LARGE, - OFF -} - diff --git a/clients/android/NewsBlur/src/com/newsblur/util/ThumbnailStyle.kt b/clients/android/NewsBlur/src/com/newsblur/util/ThumbnailStyle.kt new file mode 100644 index 000000000..122ad3212 --- /dev/null +++ b/clients/android/NewsBlur/src/com/newsblur/util/ThumbnailStyle.kt @@ -0,0 +1,18 @@ +package com.newsblur.util + +enum class ThumbnailStyle { + LEFT_SMALL, + LEFT_LARGE, + RIGHT_SMALL, + RIGHT_LARGE, + OFF, + ; + + fun isLeft() = this == LEFT_SMALL || this == LEFT_LARGE + + fun isRight() = this == RIGHT_SMALL || this == RIGHT_LARGE + + fun isSmall() = this == RIGHT_SMALL || this == LEFT_SMALL + + fun isOff() = this == OFF +} \ No newline at end of file diff --git a/clients/android/NewsBlur/src/com/newsblur/view/StoryThumbnailView.kt b/clients/android/NewsBlur/src/com/newsblur/view/StoryThumbnailView.kt index 4822fbab3..f74d580f5 100644 --- a/clients/android/NewsBlur/src/com/newsblur/view/StoryThumbnailView.kt +++ b/clients/android/NewsBlur/src/com/newsblur/view/StoryThumbnailView.kt @@ -16,7 +16,7 @@ class StoryThumbnailView } fun setThumbnailStyle(thumbnailStyle: ThumbnailStyle) { - if (thumbnailStyle == ThumbnailStyle.LEFT_SMALL || thumbnailStyle == ThumbnailStyle.RIGHT_SMALL) { + if (thumbnailStyle.isSmall()) { setBackgroundResource(R.drawable.shape_rounded_corners_6dp) } else { setBackgroundResource(0)