From abe6ff2bf6bad57d77adb19c2634ee6ddd7dc49e Mon Sep 17 00:00:00 2001 From: Samuel Clay Date: Thu, 17 May 2012 14:42:34 -0700 Subject: [PATCH] Feed header shadows now match the favicon color, but 10% darker. This makes the feed title floater look much better. --- media/css/reader.css | 8 ++++---- media/js/newsblur/reader/reader.js | 2 ++ media/js/newsblur/reader/reader_utils.js | 4 ++-- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/media/css/reader.css b/media/css/reader.css index 708040d23..510d94870 100644 --- a/media/css/reader.css +++ b/media/css/reader.css @@ -1717,11 +1717,11 @@ background: transparent; padding: 2px 0; color: white; font-size: 13px; - text-shadow: 0 1px 0 #000; +/* text-shadow: 0 1px 0 #000;*/ } #story_pane .NB-inverse .NB-feed-story-feed { color: black; - text-shadow: 0 1px 0 #E0E0E0; +/* text-shadow: 0 1px 0 #E0E0E0;*/ } #story_pane .NB-feed-story-feed .feed_favicon { @@ -1738,12 +1738,12 @@ background: transparent; } #story_pane .NB-feed-story-feed .NB-feed-story-header-title:hover { color: #DFE2F3; - text-shadow: 0 1px 0 #000; +/* text-shadow: 0 1px 0 #000;*/ } #story_pane .NB-inverse .NB-feed-story-feed .NB-feed-story-header-title:hover { color: #274C63; - text-shadow: 0 1px 0 #E0E0E0; +/* text-shadow: 0 1px 0 #E0E0E0;*/ } #story_pane .NB-feed-stories .NB-feed-story img { diff --git a/media/js/newsblur/reader/reader.js b/media/js/newsblur/reader/reader.js index 798161ba7..39220a1d4 100644 --- a/media/js/newsblur/reader/reader.js +++ b/media/js/newsblur/reader/reader.js @@ -4261,6 +4261,7 @@ if (this.cache.last_feed_view_story_feed_id == story.story_feed_id) { river_same_feed = 'NB-feed-story-river-same-feed'; } + console.log(["feed story", NEWSBLUR.utils.generate_gradient(feed, 'border')]); var $story = $.make('li', { className: 'NB-feed-story ' + read + starred + shared + river_stories + ' NB-story-' + score_color }, [ $.make('div', { className: 'NB-feed-story-header' }, [ $.make('div', { className: 'NB-feed-story-header-feed' }, [ @@ -4274,6 +4275,7 @@ .css('background-image', NEWSBLUR.utils.generate_gradient(feed, 'moz')) .css('borderBottom', NEWSBLUR.utils.generate_gradient(feed, 'border')) .css('borderTop', NEWSBLUR.utils.generate_gradient(feed, 'border')) + .css('textShadow', '0 1px 0 ' + NEWSBLUR.utils.generate_gradient(feed, 'border-color')) .toggleClass('NB-inverse', NEWSBLUR.utils.is_feed_floater_gradient_light(feed)), $.make('div', { className: 'NB-feed-story-header-info' }, [ (story.story_authors && diff --git a/media/js/newsblur/reader/reader_utils.js b/media/js/newsblur/reader/reader_utils.js index fc2ea87f1..93614ac66 100644 --- a/media/js/newsblur/reader/reader_utils.js +++ b/media/js/newsblur/reader/reader_utils.js @@ -25,9 +25,9 @@ NEWSBLUR.utils = { var g = parseInt(color.substr(2, 2), 16); var b = parseInt(color.substr(4, 2), 16); - if (type == 'border') { + if (type == 'border' || type == 'border-color') { return [ - '1px solid rgb(', + (type == 'border' ? '1px solid ' : '') + 'rgb(', [ parseInt(r*(6/8), 10), parseInt(g*(6/8), 10),