public-mirrors/NewsBlur
1
0
Fork 0
mirror of https://github.com/samuelclay/NewsBlur.git synced 2025-09-18 21:50:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Greatly improving performance of loading the feed chooser modal. Almost 1600ms -> 260ms. That's 6x as fast now.

Browse source
This commit is contained in:
Samuel Clay 2010-09-29 09:49:34 -04:00
parent 1c734528de
commit 9e6d0b7344
1 changed files with 31 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
media/js/newsblur/reader_feedchooser.js
View file

@ -10,10 +10,12 @@ NEWSBLUR.ReaderFeedchooser = function(options) {
NEWSBLUR.ReaderFeedchooser.prototype = { NEWSBLUR.ReaderFeedchooser.prototype = {
runner: function() { runner: function() {
this.start = new Date();
this.MAX_FEEDS = 40; this.MAX_FEEDS = 40;
this.approve_list = []; this.approve_list = [];
this.make_modal(); this.make_modal();
this.open_modal(); this.open_modal();
this.find_feeds_in_feed_list();
this.initial_load_feeds(); this.initial_load_feeds();
this.$modal.bind('mousedown', $.rescope(this.handle_click, this)); this.$modal.bind('mousedown', $.rescope(this.handle_click, this));
@ -93,37 +95,42 @@ NEWSBLUR.ReaderFeedchooser.prototype = {
}); });
}, },
add_feed_to_decline: function(feed_id) { add_feed_to_decline: function(feed_id, update) {
this.approve_list = _.without(this.approve_list, feed_id); this.approve_list = _.without(this.approve_list, feed_id);
var $feed = this.find_feed_in_feed_list(feed_id); var $feed = this.$feeds[feed_id];
$feed.removeClass('NB-feedchooser-approve'); $feed.removeClass('NB-feedchooser-approve');
$feed.addClass('NB-feedchooser-decline'); $feed.addClass('NB-feedchooser-decline');
this.update_counts(); if (update) {
this.update_counts();
}
}, },
add_feed_to_approve: function(feed_id) { add_feed_to_approve: function(feed_id, update) {
if (!_.contains(this.approve_list, feed_id)) { if (!_.contains(this.approve_list, feed_id)) {
this.approve_list.push(feed_id); this.approve_list.push(feed_id);
var $feed = this.find_feed_in_feed_list(feed_id); var $feed = this.$feeds[feed_id];
$feed.removeClass('NB-feedchooser-decline'); $feed.removeClass('NB-feedchooser-decline');
$feed.addClass('NB-feedchooser-approve'); $feed.addClass('NB-feedchooser-approve');
if (update) {
this.update_counts();
}
} }
this.update_counts();
}, },
find_feed_in_feed_list: function(feed_id) { find_feeds_in_feed_list: function() {
var $feed_list = $('.NB-feedchooser', this.$modal); var $feed_list = $('.NB-feedchooser', this.$modal);
var $feeds = $([]); var $feeds = {};
$('.feed', $feed_list).each(function() { $('.feed', $feed_list).each(function() {
if ($(this).data('feed_id') == feed_id) { var feed_id = $(this).data('feed_id');
$feeds.push($(this).get(0)); if (!_.contains(_.keys($feeds), feed_id)) {
$feeds[feed_id] = $([]);
} }
$feeds[feed_id].push($(this).get(0));
}); });
return $feeds; this.$feeds = $feeds;
}, },
update_counts: function() { update_counts: function() {
@ -148,12 +155,12 @@ NEWSBLUR.ReaderFeedchooser.prototype = {
}, },
initial_load_feeds: function() { initial_load_feeds: function() {
var start = new Date();
var self = this; var self = this;
var $feeds = $('.feed', this.$modal); var $feeds = $('.feed', this.$modal);
var feeds = this.model.get_feeds(); var feeds = this.model.get_feeds();
var active_feeds = _.any(_.pluck(feeds, 'active')); var active_feeds = _.any(_.pluck(feeds, 'active'));
if (!active_feeds) { if (!active_feeds) {
// Get feed subscribers // Get feed subscribers
var min_subscribers = _.last( var min_subscribers = _.last(
@ -166,25 +173,23 @@ NEWSBLUR.ReaderFeedchooser.prototype = {
); );
// Decline everything // Decline everything
var feeds = []; var approve_feeds = [];
$feeds.each(function() { _.each(feeds, function(feed, feed_id) {
var feed_id = $(this).data('feed_id'); self.add_feed_to_decline(parseInt(feed_id, 10));
self.add_feed_to_decline(feed_id); if (feed['subs'] >= min_subscribers) {
approve_feeds.push(parseInt(feed_id, 10));
if (self.model.get_feed(feed_id)['subs'] >= min_subscribers) {
feeds.push(feed_id);
} }
}); });
// Approve feeds in subs // Approve feeds in subs
_.each(feeds, function(feed_id) { _.each(approve_feeds, function(feed_id) {
if (self.model.get_feed(feed_id)['subs'] > min_subscribers && if (self.model.get_feed(feed_id)['subs'] > min_subscribers &&
self.approve_list.length < self.MAX_FEEDS) { self.approve_list.length < self.MAX_FEEDS) {
self.add_feed_to_approve(feed_id); self.add_feed_to_approve(feed_id);
} }
}); });
_.each(feeds, function(feed_id) { _.each(approve_feeds, function(feed_id) {
if (self.model.get_feed(feed_id)['subs'] == min_subscribers && if (self.model.get_feed(feed_id)['subs'] == min_subscribers &&
self.approve_list.length < self.MAX_FEEDS) { self.approve_list.length < self.MAX_FEEDS) {
self.add_feed_to_approve(feed_id); self.add_feed_to_approve(feed_id);
@ -195,6 +200,7 @@ NEWSBLUR.ReaderFeedchooser.prototype = {
var active_feeds = _.pluck(_.select(feeds, function(feed) { var active_feeds = _.pluck(_.select(feeds, function(feed) {
if (feed.active) return true; if (feed.active) return true;
}), 'id'); }), 'id');
this.approve_list = active_feeds;
// Approve or decline // Approve or decline
var feeds = []; var feeds = [];
@ -208,6 +214,7 @@ NEWSBLUR.ReaderFeedchooser.prototype = {
} }
}); });
} }
this.update_counts();
}, },
save: function() { save: function() {
@ -232,9 +239,9 @@ NEWSBLUR.ReaderFeedchooser.prototype = {
var feed_id = $t.data('feed_id'); var feed_id = $t.data('feed_id');
if (_.contains(this.approve_list, feed_id)) { if (_.contains(this.approve_list, feed_id)) {
this.add_feed_to_decline(feed_id); this.add_feed_to_decline(feed_id, true);
} else { } else {
this.add_feed_to_approve(feed_id); this.add_feed_to_approve(feed_id, true);
} }
}, this)); }, this));