public-mirrors/NewsBlur
1
0
Fork 0
mirror of https://github.com/samuelclay/NewsBlur.git synced 2025-09-18 21:50:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

migrate off deprecated Fragment.onAttach API

Browse source
This commit is contained in:
dosiecki 2016-04-29 03:57:40 -07:00
parent 2817b4b9bc
commit 921780df9e
2 changed files with 7 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
clients/android/NewsBlur/src/com/newsblur/fragment/MarkAllReadDialogFragment.java
View file

@ -18,8 +18,6 @@ public class MarkAllReadDialogFragment extends DialogFragment {
void onMarkAllRead(FeedSet feedSet);
}
private MarkAllReadDialogListener listener;
public static MarkAllReadDialogFragment newInstance(FeedSet feedSet) {
MarkAllReadDialogFragment fragment = new MarkAllReadDialogFragment();
Bundle args = new Bundle();
@ -28,12 +26,6 @@ public class MarkAllReadDialogFragment extends DialogFragment {
return fragment;
}
@Override
public void onAttach(Activity activity) {
super.onAttach(activity);
listener = (MarkAllReadDialogListener)activity;
}
@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
@ -50,6 +42,7 @@ public class MarkAllReadDialogFragment extends DialogFragment {
title = FeedUtils.getFeed(feedSet.getSingleFeed()).title;
}
final MarkAllReadDialogListener listener = (MarkAllReadDialogListener) getActivity();
builder.setTitle(title)
.setItems(R.array.mark_all_read_options, new DialogInterface.OnClickListener() {
public void onClick(DialogInterface dialog, int which) {

19
clients/android/NewsBlur/src/com/newsblur/fragment/ReadingItemFragment.java
View file

@ -75,7 +75,6 @@ public class ReadingItemFragment extends NbFragment implements ClassifierDialogF
@Bind(R.id.reading_item_tags) FlowLayout tagContainer;
private View view;
private UserDetails user;
private Reading activity;
private DefaultFeedView selectedFeedView;
@Bind(R.id.save_story_button) Button saveButton;
@Bind(R.id.share_story_button) Button shareButton;
@ -119,14 +118,6 @@ public class ReadingItemFragment extends NbFragment implements ClassifierDialogF
return readingFragment;
}
@Override
public void onAttach(Activity activity) {
if (activity instanceof Reading) {
this.activity = (Reading) activity;
}
super.onAttach(activity);
}
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
@ -188,9 +179,11 @@ public class ReadingItemFragment extends NbFragment implements ClassifierDialogF
view = inflater.inflate(R.layout.fragment_readingitem, null);
ButterKnife.bind(this, view);
Reading activity = (Reading) getActivity();
// the share/save buttons us compound drawables for layout speed, but they
// cannot correctly compute padding. hard resize the icons to use padding.
int iconSizePx = UIUtils.dp2px(this.activity, 30);
int iconSizePx = UIUtils.dp2px(activity, 30);
Drawable shareButtonIcon = shareButton.getCompoundDrawables()[0];
shareButtonIcon.setBounds(0, 0, iconSizePx, iconSizePx);
shareButton.setCompoundDrawables(shareButtonIcon, null, null, null);
@ -210,7 +203,7 @@ public class ReadingItemFragment extends NbFragment implements ClassifierDialogF
setupItemCommentsAndShares();
NonfocusScrollview scrollView = (NonfocusScrollview) view.findViewById(R.id.reading_scrollview);
scrollView.registerScrollChangeListener(this.activity);
scrollView.registerScrollChangeListener(activity);
setupImmersiveViewGestureDetector();
@ -275,9 +268,9 @@ public class ReadingItemFragment extends NbFragment implements ClassifierDialogF
@OnClick(R.id.save_story_button) void clickSave() {
if (story.starred) {
FeedUtils.setStorySaved(story, false, activity);
FeedUtils.setStorySaved(story, false, getActivity());
} else {
FeedUtils.setStorySaved(story,true, activity);
FeedUtils.setStorySaved(story,true, getActivity());
}
}