public-mirrors/NewsBlur
1
0
Fork 0
mirror of https://github.com/samuelclay/NewsBlur.git synced 2025-09-18 21:50:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix async crashes

Browse source
This commit is contained in:
dosiecki 2017-08-29 16:51:45 -07:00
parent 0163dd7e4d
commit 69991e711d
1 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
clients/android/NewsBlur/src/com/newsblur/database/StoryItemsAdapter.java
View file

@ -6,6 +6,7 @@ import android.graphics.Color;
import android.graphics.Typeface;
import android.text.TextUtils;
import android.view.View;
import android.view.ViewGroup;
import android.widget.ImageView;
import android.widget.TextView;
import android.widget.SimpleCursorAdapter;
@ -111,11 +112,32 @@ public class StoryItemsAdapter extends SimpleCursorAdapter {
@Override
public synchronized long getItemId(int position) {
if (cursor == null || cursor.isClosed() || cursor.getColumnCount() == 0 || position >= cursor.getCount() || position < 0) return 0;
return super.getItemId(position);
try {
return super.getItemId(position);
} catch (IllegalStateException ise) {
// despite all the checks above, this can still async fail if the curor is closed by the loader outside of our control
return 0;
}
}
@Override
public synchronized View getView(int position, View convertView, ViewGroup parent) {
if (cursor == null || cursor.isClosed() || cursor.getColumnCount() == 0 || position >= cursor.getCount() || position < 0) return new View(context);
try {
return super.getView(position, convertView, parent);
} catch (IllegalStateException ise) {
// despite all the checks above, this can still async fail if the curor is closed by the loader outside of our control
return new View(context);
}
}
@Override
public synchronized void bindView(View v, Context context, Cursor cursor) {
// see if this is a valid view for us to bind
if (v.findViewById(R.id.row_item_title) == null) {
com.newsblur.util.Log.w(this, "asked to bind wrong type of view");
return;
}
super.bindView(v, context, cursor);
TextView itemTitle = (TextView) v.findViewById(R.id.row_item_title);