From 672270734a95fa4ed19d883cc7c2d8065995c3b2 Mon Sep 17 00:00:00 2001 From: Samuel Clay Date: Sat, 4 Sep 2010 17:02:26 -0400 Subject: [PATCH] Connecting About and FAQ modals together. Finishing up About modal, and all FAQ questions. --- media/css/reader.css | 28 +++- .../reader/intelligence_slider_negative.png | Bin 0 -> 1189 bytes .../reader/intelligence_slider_positive.png | Bin 1066 -> 1070 bytes media/js/jquery.simplemodal-1.3.js | 17 +- media/js/newsblur/about.js | 65 ++++---- media/js/newsblur/faq.js | 151 ++++++++++-------- media/js/newsblur/reader.js | 2 +- media/js/newsblur/reader_classifier.js | 1 - 8 files changed, 158 insertions(+), 106 deletions(-) create mode 100644 media/img/reader/intelligence_slider_negative.png diff --git a/media/css/reader.css b/media/css/reader.css index 77e7015f4..e461f7567 100644 --- a/media/css/reader.css +++ b/media/css/reader.css @@ -2788,7 +2788,7 @@ background: transparent; /* =============== */ .NB-modal-about ul { - margin: 2px 0 4px; + margin: 2px 12px 4px 0; padding: 0 0 1px; font-size: 13px; } @@ -2810,7 +2810,7 @@ background: transparent; background: transparent url('../img/icons/silk/bullet_yellow.png') no-repeat 0 0; } .NB-modal-about ul.NB-about-client li { - background: transparent url('../img/icons/silk/bullet_orange.png') no-repeat 0 0; + background: transparent url('../img/icons/silk/bullet_red.png') no-repeat 0 0; } .NB-modal-about ul.NB-about-who li { background: transparent url('../img/icons/silk/bullet_green.png') no-repeat 0 0; @@ -2820,3 +2820,27 @@ background: transparent; float: right; line-height: 30px; } + +.NB-modal-about ul li .NB-faq-question { + display: block; + font-weight: bold; + margin: 0 0 10px 0; +} + +.NB-modal-about ul li .NB-faq-answer { + line-height: 18px; + color: #404040; + margin: 0 0 16px 0; + font-size: 12px; +} + +.NB-modal-about ul li .NB-faq-answer.last { + margin-bottom: 0; +} + +.NB-modal-about .NB-faq-image { + float: right; + border-color:#C0C0C0 #A0A0A0 #A0A0A0 #C0C0C0; + border-style:solid; + border-width:1px; +} \ No newline at end of file diff --git a/media/img/reader/intelligence_slider_negative.png b/media/img/reader/intelligence_slider_negative.png new file mode 100644 index 0000000000000000000000000000000000000000..5fb351dc56c38420c236a0c2e3e2f9cfd5b4985f GIT binary patch literal 1189 zcmV;W1X}xvP)>-8mxagyfRn4p*nLeqyL`T|Y+ zP|8I}NJvPvct>i)7vMeOV}wY20H+8vAGM+TBEoYp z?)^-u1cR?lH(S}E`QrCk9NXrV=gwid7I$~oh%0ffU-+cPRywqn=5lzK-oU-}6ZXP9 zvEc!>ayO1$cq1uo=J0wZarH&)2lK>wUuA10*KAowVnLhd<>Um*dw00Kdz+q)UglT7 zliErhX?fu8<#F@-2-CtV>J(9rRdl1VEbv?p&v}Tjbv(zTXf#{Z(Ga#kw~H7h9mlh= z923{{q_)x=DY99N-1hHhZk18;uyqQq&gd7?{LU9d_22=p1dWHe4Bc zll2FGaJq9C(=jRJ_qqDQ+frL;j&wAQote+ka$lmOkj!QopZb_odgR!}Hwwql*jbrD zyOTpVAUT$0d~%9ZU+YYEc8qPlTDidwE8pT;9&e4k!?o8xV(8TA8e92fC#2;F*O6^P z=*TvqX0o%kZSv!~!A9PuM!!BdY#+&N zRk%%gwDAGn%BWsAv#;>zv9bK=??;U=6{Tx-V+%H(`)$MoRuP@hk z^?+K!;{qTVxLs1T#{xoVNQd1UHp9G9T0fYMgsr<1E@(vK~!jg?U`L`BUK#6 ze=}*`lQ!E;n{L_Gs&v&w5WNt$d$CydTD;hR*P_Lb5&Rfc!TanAiio16S3*%)#N95X zQrtzHrb+9jNoG2)=XkLaEuExWOd1o;59VTq|G;zR;hg`=Xi`c5iDIbH2Q5I+8+6oe ze;f(ajvNt`kt4!b=u^Xhk5}<;m+>UXTSemUuMnA?J!g6U0mp#KDt@($=YhOfBtE}F zBsn~5*tctZ`NtQm8*30qZcH!p*23H5Q&T5mHTiehdW;WC2sFg?Ye>h&+V}}q*O@An z&Ov^UcvM124KaQVDSWKGA8}pD)T^aIe=B=xKHd2Q-}QJQa}_6W*gn`IrbT)0wGU3j zh90f%?K0x}8w5XmkGH-?w2-G#zSDQ%y~N!uBPNyz%niK9YeaLePr)akfzCDy-A{2?5pTrBlAUC#s-P} z5+dSLd-My5x#3#Fjj3fGKHgy_S-|#fnvDi;&fN@+4b73hVNhHB2&4QN78>bdk;RpF z$+djq zp>QHLyx36;9jcEU5tNZ5f--VM2%qdI2F{;WK&5^}({>5OlQJfvYh)8KW^zd;Q^(uE zuEkCe2)6cGZ0|L(J<(s~iZ(A_zJTp`Z4Bo$b9Q3;A?!RVq%UX}hFi(Np76u_#U3 zZQpk^()NTpP6t3BWIHEze?!-`b`b11ZnU1+q2uZcx;<-YWeELatRDVDIhx~TnP-|G^Ofm@)(c=RF+w-Wm zY^KIjJbUpe1_Fw~vTp|L){ih9x1BR}T_YWjaVeK1pFYEgPBA>F-eN@f3vZjCKoG5K QIRF3v07*qoM6N<$g0V>BM*si- delta 990 zcmV<410npb2&xE>I|~aE000XT0n*)m{EHKn<2C>Q1EfhrK~!jg?U`L`990~~ ze>0nX-%YmZCYy#PMkQ5?AbKG-y(orWix*w+S~U1E7C%N*@P1oC5m7YcN(d@NY*Ruc z*dk6gyNTWG>`dnM952L3+)2`u-K@KuAI#0+Kk&>vob!JTPCPi@qLgN%Oq!)h@}VT z8+M%rU;gn0tHuh1k{gqYyfybW#mq!xyw*{*epo@EA+BFTx(@c*Pk6e{M5S^L^1H;N z3PNg#(Q8N%VDJ2h=Se1Bt@K;j6Z7fTe$Y5EI(5vky`am&xLmrZ@Y>ZTOhR7@E@-bFT6tSLABqq&cv#*!hH56?ltdo zckeD^sRG|^d~#68&<9Z-Mfd~$ezJ&+`mep@ne`iDb z0?Th>dlrH4aRUe8gvZ8r@@5;pReEH+Xr70x`M@LZgT7OcbL3Tij40p zb`%4N>LZ5)W#o{cj2sd=Cp(J1^QRqBYaU=a9-;WVgo)`I`BZ|bLYnbRXFGUou@i=Z zjh!}|J0^}VdaGP<$jg^6;J7};(KMMv99`D{5JF;mKD(_0N@E#j$CF3ie~UCS3z{sW=tW@yI0Nr^aOxaZJZMvKDEi z;|q11_JL5y!<={$x~?4-e?k8cS+%C(I$og6><5>OpJlq|y>w+Ob*EEDU z-AExMx^{HuMjH8IDaWsMi_Mye7pT_byvU>yc)pJYCqAC*7e45pLB!Pv3jhEB M07*qoM6N<$f<$QOQUCw| diff --git a/media/js/jquery.simplemodal-1.3.js b/media/js/jquery.simplemodal-1.3.js index dd73a14e9..c1faffe73 100644 --- a/media/js/jquery.simplemodal-1.3.js +++ b/media/js/jquery.simplemodal-1.3.js @@ -6,6 +6,13 @@ * Revision: $Id$ */ +/* + + Samuel Clay + - Added callback on $.modal.close(); + +*/ + /** * SimpleModal is a lightweight jQuery plugin that provides a simple * interface to create a modal dialog. @@ -78,8 +85,8 @@ /* * Close the modal dialog. */ - $.modal.close = function () { - $.modal.impl.close(); + $.modal.close = function (callback) { + $.modal.impl.close(callback); }; /* @@ -631,7 +638,7 @@ * function was internal or external. If it was external, the * onClose callback will be ignored */ - close: function () { + close: function (callback) { var s = this; // prevent close when dialog does not exist @@ -647,7 +654,7 @@ s.occb = true; // execute the onClose callback - s.o.onClose.apply(s, [s.d]); + s.o.onClose.apply(s, [s.d, callback]); } else { // if the data came from the DOM, put it back @@ -680,6 +687,8 @@ // reset the dialog object s.d = {}; + + $.isFunction(callback) && callback(); }, 10); } } diff --git a/media/js/newsblur/about.js b/media/js/newsblur/about.js index 5254ad9e3..d0b663d9a 100644 --- a/media/js/newsblur/about.js +++ b/media/js/newsblur/about.js @@ -8,7 +8,6 @@ NEWSBLUR.About = function(options) { NEWSBLUR.About.prototype = { runner: function() { - $.modal.close(); this.make_modal(); this.open_modal(); @@ -35,6 +34,33 @@ NEWSBLUR.About.prototype = { ]) ]) ]), + $.make('div', { className: 'NB-fieldset NB-modal-submit' }, [ + $.make('h5', [ + $.make('div', { className: 'NB-exception-option-meta' }), + $.make('span', { className: 'NB-exception-option-option' }, 'Who:'), + 'A Labor of Love' + ]), + $.make('div', { className: 'NB-fieldset-fields' }, [ + $.make('ul', { className: 'NB-about-who' }, [ + $.make('li', [ + 'Hand-crafted by: ', + $.make('a', { href: 'http://www.samuelclay.com' }, 'Samuel Clay') + ]), + $.make('li', [ + 'Find him on Twitter: ', + $.make('a', { href: 'http://twitter.com/samuelclay' }, '@samuelclay') + ]), + $.make('li', [ + 'E-mail: ', + $.make('a', { href: 'mailto:samuel@ofbrooklyn.com' }, 'samuel@ofbrooklyn.com') + ]), + $.make('li', { className: 'last' }, [ + 'Made in: ', + $.make('a', { href: 'http://www.newyorkfieldguide.com' }, 'New York City') + ]) + ]) + ]) + ]), $.make('div', { className: 'NB-fieldset NB-modal-submit' }, [ $.make('h5', [ $.make('div', { className: 'NB-exception-option-meta' }), @@ -91,33 +117,6 @@ NEWSBLUR.About.prototype = { ]) ]) ]) - ]), - $.make('div', { className: 'NB-fieldset NB-modal-submit' }, [ - $.make('h5', [ - $.make('div', { className: 'NB-exception-option-meta' }), - $.make('span', { className: 'NB-exception-option-option' }, 'Who:'), - 'A Feed Reader with Intelligence' - ]), - $.make('div', { className: 'NB-fieldset-fields' }, [ - $.make('ul', { className: 'NB-about-who' }, [ - $.make('li', [ - 'Hand-crafted by: ', - $.make('a', { href: 'http://www.samuelclay.com' }, 'Samuel Clay') - ]), - $.make('li', [ - 'Find him on Twitter: ', - $.make('a', { href: 'http://twitter.com/samuelclay' }, '@samuelclay') - ]), - $.make('li', [ - 'E-mail him at: ', - $.make('a', { href: 'mailto:samuel@ofbrooklyn.com' }, 'samuel@ofbrooklyn.com') - ]), - $.make('li', { className: 'last' }, [ - 'Made in: ', - $.make('a', { href: 'http://www.newyorkfieldguide.com' }, 'New York City') - ]) - ]) - ]) ]) ]); }, @@ -138,12 +137,12 @@ NEWSBLUR.About.prototype = { 'onShow': function(dialog) { $('#simplemodal-container').corner('6px'); }, - 'onClose': function(dialog) { + 'onClose': function(dialog, callback) { dialog.data.hide().empty().remove(); dialog.container.hide().empty().remove(); dialog.overlay.fadeOut(200, function() { dialog.overlay.empty().remove(); - $.modal.close(); + $.modal.close(callback); }); $('.NB-modal-holder').empty().remove(); } @@ -168,8 +167,10 @@ NEWSBLUR.About.prototype = { $.targetIs(e, { tagSelector: '.NB-link-about-faq' }, function($t, $p) { e.preventDefault(); - - NEWSBLUR.faq = new NEWSBLUR.Faq(); + + $.modal.close(function() { + NEWSBLUR.faq = new NEWSBLUR.Faq(); + }); }); } diff --git a/media/js/newsblur/faq.js b/media/js/newsblur/faq.js index 924d0010f..56017b918 100644 --- a/media/js/newsblur/faq.js +++ b/media/js/newsblur/faq.js @@ -20,101 +20,118 @@ NEWSBLUR.Faq.prototype = { this.$modal = $.make('div', { className: 'NB-modal-about NB-modal-exception NB-modal' }, [ $.make('a', { href: '#faq', className: 'NB-link-about-faq' }, 'About NewsBlur'), - $.make('h2', { className: 'NB-modal-title' }, 'Frequently [enough] Asked Question'), + $.make('h2', { className: 'NB-modal-title' }, 'Frequently Asked Questions'), $.make('div', { className: 'NB-fieldset NB-modal-submit' }, [ $.make('h5', [ - $.make('div', { className: 'NB-exception-option-meta' }), - $.make('span', { className: 'NB-exception-option-option' }, 'What:'), - 'A Feed Reader with Intelligence' + 'The Reader' ]), $.make('div', { className: 'NB-fieldset-fields' }, [ $.make('ul', { className: 'NB-about-what' }, [ - $.make('li', 'Read the original site or the RSS feed.'), - $.make('li', 'Automatically highlight stories you want to read.'), - $.make('li', { className: 'last' }, 'Filter out stories you don\'t want to read.') + $.make('li', [ + $.make('div', { className: 'NB-faq-question' }, 'What is the different between the three views: Original, Feed, and Story?'), + $.make('div', { className: 'NB-faq-answer' }, 'Original view is the original site. Feed view is the RSS feed from the site. And Story view is the same as Feed view, but only shows one story at a time. It\'s all personal preference, really.') + ]), + $.make('li', [ + $.make('div', { className: 'NB-faq-question' }, 'Am I actually at the original site? Can NewsBlur see what I see?'), + $.make('div', { className: 'NB-faq-answer' }, 'In order to show you the original site, NewsBlur takes a snapshot of the page. You may have noticed that if you are logged into the original site, you are not logged into NewsBlur\'s snapshot of the page. This is because NewsBlur fetched the site for you.') + ]), + $.make('li', { className: 'last' }, [ + $.make('div', { className: 'NB-faq-question' }, 'Why doesn\'t NewsBlur follow me when I click on links on the page?'), + $.make('div', { className: 'NB-faq-answer' }, 'When you click on a link, you are technically leaving NewsBlur, although only for a portion of the page. In order to track what you\'re reading, you need to read NewsBlur\'s snapshot of the page, or switch to the Feed view.'), + $.make('div', { className: 'NB-faq-answer last' }, 'This may change one day. There is a way to fix this behavior so it works like you would expect. It is not easy to do, however. One day.') + ]) ]) ]) ]), $.make('div', { className: 'NB-fieldset NB-modal-submit' }, [ $.make('h5', [ - $.make('div', { className: 'NB-exception-option-meta' }), - $.make('span', { className: 'NB-exception-option-option' }, 'How:'), - 'Server-side technologies' + 'The Intelligence' ]), $.make('div', { className: 'NB-fieldset-fields' }, [ $.make('ul', { className: 'NB-about-server' }, [ $.make('li', [ - $.make('a', { href: 'http://www.djangoproject.com' }, 'Django'), - ': Web framework written in Python, used to serve all pages.' - ]), - $.make('li', [ - $.make('a', { href: 'http://ask.github.com/celery' }, 'Celery'), - ' & ', - $.make('a', { href: 'http://www.rabbitmq.com' }, 'RabbitMQ'), - ': Asynchronous queueing server, used to fetch and parse RSS feeds.' - ]), - $.make('li', [ - $.make('a', { href: 'http://www.mongodb.com' }, 'MongoDB'), - ', ', - $.make('a', { href: 'http://www.mongodb.com/pymongo' }, 'Pymongo'), - ', & ', - $.make('a', { href: 'http://www.github.com/hmarr/mongoengine' }, 'Mongoengine'), - ': Non-relational database, used to store stories, read stories, feed/page fetch histories, and proxied sites.' + $.make('div', { className: 'NB-faq-question' }, [ + 'What does the three-color slider do?' + ]), + $.make('div', { className: 'NB-faq-answer' }, [ + $.make('img', { src: NEWSBLUR.Globals.MEDIA_URL + '/img/reader/intelligence_slider_positive.png', className: 'NB-faq-image', width: 114, height: 29 }), + 'This is called the intelligence slider. Slide it to the right to only show stories you like.' + ]), + $.make('div', { className: 'NB-faq-answer last' }, [ + $.make('img', { src: NEWSBLUR.Globals.MEDIA_URL + '/img/reader/intelligence_slider_negative.png', className: 'NB-faq-image', width: 114, height: 29 }), + 'Slide it to the left to show stories you dislike. Stories all start off neutral, in the center of the slider.' + ]), + $.make('div', { className: 'NB-faq-answer' }, [ + $.make('br'), + $.make('img', { className: 'NB-trainer-bullet', src: NEWSBLUR.Globals.MEDIA_URL + '/img/icons/silk/bullet_red.png'}), + ' are stories you don\'t like', + $.make('br'), + $.make('img', { className: 'NB-trainer-bullet', src: NEWSBLUR.Globals.MEDIA_URL + '/img/icons/silk/bullet_yellow.png'}), + ' are stories you have not yet rated', + $.make('br'), + $.make('img', { className: 'NB-trainer-bullet', src: NEWSBLUR.Globals.MEDIA_URL + '/img/icons/silk/bullet_green.png'}), + ' are stories you like' + ]) ]), $.make('li', { className: 'last' }, [ - $.make('a', { href: 'http://www.postgresql.com' }, 'PostgreSQL'), - ': Relational database, used to store feeds, subscriptions, and user accounts.' + $.make('div', { className: 'NB-faq-question' }, 'How does NewsBlur know whether I like or dislike a story?'), + $.make('div', { className: 'NB-faq-answer' }, 'When you like or dislike a story, you mark a facet of that story by checking a tag, author, part of the title, or entire publisher. When these facets are found in future stories, the stories are then weighted with your preferences. It is a very simple, explicit process where you tell NewsBlur what you like and don\'t like.'), + $.make('div', { className: 'NB-faq-answer' }, 'The idea is that by explicitly telling NewsBlur what your story preferences are, there is increased likelihood that you will like what the intelligence slider does for you.'), + $.make('div', { className: 'NB-faq-answer last'}, 'Currently, there is not an automated way of detecting stories you like or dislike without having to train NewsBlur. This implicit, automatic intelligence will come in the near-term future, but it will require an evolution to the interface that has not been easy to figure out how to make in a simple, clear, and effective manner. Soon.') ]) ]) ]) ]), $.make('div', { className: 'NB-fieldset NB-modal-submit' }, [ $.make('h5', [ - $.make('div', { className: 'NB-exception-option-meta' }), - $.make('span', { className: 'NB-exception-option-option' }, 'How:'), - 'Client-side and design' - ]), - $.make('div', { className: 'NB-fieldset-fields' }, [ - $.make('ul', { className: 'NB-about-client' }, [ - $.make('li', [ - $.make('a', { href: 'http://www.jquery.com' }, 'jQuery'), - ': Cross-browser compliant JavaScript code. IE works without effort.' - ]), - $.make('li', [ - $.make('a', { href: 'http://documentcloud.github.com/underscore/' }, 'Underscore.js'), - ': Functional programming for JavaScript. Indispensible.' - ]), - $.make('li', [ - $.make('b', 'Miscellaneous jQuery Plugins:'), - ' Everything from resizable layouts, to progress bars, sortables, date handling, colors, corners, JSON, animations. See the complete list on ', - $.make('a', { href: 'http://github.com/samuelclay/NewsBlur/' }, 'NewsBlur\'s GitHub repository') - ]) - ]) - ]) - ]), - $.make('div', { className: 'NB-fieldset NB-modal-submit' }, [ - $.make('h5', [ - $.make('div', { className: 'NB-exception-option-meta' }), - $.make('span', { className: 'NB-exception-option-option' }, 'Who:'), - 'A Feed Reader with Intelligence' + $.make('span', { className: 'NB-exception-option-option', style: 'float:right' }, 'September - October 2010'), + 'What\'s Coming' ]), $.make('div', { className: 'NB-fieldset-fields' }, [ $.make('ul', { className: 'NB-about-who' }, [ $.make('li', [ - 'Hand-crafted by: ', - $.make('a', { href: 'http://www.samuelclay.com' }, 'Samuel Clay') + $.make('div', { className: 'NB-faq-answer' }, 'An iPhone app.') ]), $.make('li', [ - 'Find him on Twitter: ', - $.make('a', { href: 'http://twitter.com/samuelclay' }, '@samuelclay') + $.make('div', { className: 'NB-faq-answer' }, 'Indication of story titles that are below the intelligence slider threshold.') ]), $.make('li', [ - 'E-mail him at: ', - $.make('a', { href: 'mailto:samuel@ofbrooklyn.com' }, 'samuel@ofbrooklyn.com') + $.make('div', { className: 'NB-faq-answer' }, 'Sort sites alphabetically, by popularity, use, unread counts, and hiding sites with no unreads.') + ]), + $.make('li', [ + $.make('div', { className: 'NB-faq-answer' }, 'Account management, password recovery.') + ]), + $.make('li', [ + $.make('div', { className: 'NB-faq-answer' }, 'Actions on folders and sites, such as deleting, renaming, and moving them.') ]), $.make('li', { className: 'last' }, [ - 'Made in: ', - $.make('a', { href: 'http://www.newyorkfieldguide.com' }, 'New York City') + $.make('div', { className: 'NB-faq-answer last' }, 'Collapsible folders.') + ]) + ]) + ]) + ]), + $.make('div', { className: 'NB-fieldset NB-modal-submit' }, [ + $.make('h5', [ + 'Something\'s Wrong' + ]), + $.make('div', { className: 'NB-fieldset-fields' }, [ + $.make('ul', { className: 'NB-about-client' }, [ + $.make('li', [ + $.make('div', { className: 'NB-faq-question' }, 'Help! A site shows unread stories, but when I open the site, there are no unread stories to read.'), + $.make('div', { className: 'NB-faq-answer' }, 'This is a bug and has been noticed in many places. It is not easy to fix, however. But it will hopefully be fixed once and for all any day now. Just know that it has been noticed.') + ]), + $.make('li', [ + $.make('div', { className: 'NB-faq-question' }, 'Help! All of the stories are several days old and new stories are not showing up.'), + $.make('div', { className: 'NB-faq-answer' }, 'There are two potential causes for new stories that are on the site to not show up. First, sites that only have a signle subscriber tend to get updated much less often than popular sites. Additionally, the frequency that a site publishes stories (once per month or several per day) has an impact on how often the site is refreshed.'), + $.make('div', { className: 'NB-faq-answer last' }, 'Second, it is possible that a bug remains in certain circumstances where some RSS feeds are not parsed correctly, resulting in new stories not being shown. This has been noticed and sites should be gradually fixed as they are manually inspected.') + ]), + $.make('li', { className: 'last' }, [ + $.make('div', { className: 'NB-faq-question' }, 'Help! I have an issue and it\'s not mentioned here.'), + $.make('div', { className: 'NB-faq-answer last' }, [ + 'Please, please, please e-mail ', + $.make('a', { href: 'mailto:samuel@ofbrooklyn.com' }, 'samuel@ofbrooklyn.com'), + '. If you have an issue it is entirely possible that other people do, too.' + ]) ]) ]) ]) @@ -138,12 +155,12 @@ NEWSBLUR.Faq.prototype = { 'onShow': function(dialog) { $('#simplemodal-container').corner('6px'); }, - 'onClose': function(dialog) { + 'onClose': function(dialog, callback) { dialog.data.hide().empty().remove(); dialog.container.hide().empty().remove(); dialog.overlay.fadeOut(200, function() { dialog.overlay.empty().remove(); - $.modal.close(); + $.modal.close(callback); }); $('.NB-modal-holder').empty().remove(); } @@ -169,7 +186,9 @@ NEWSBLUR.Faq.prototype = { $.targetIs(e, { tagSelector: '.NB-link-about-faq' }, function($t, $p) { e.preventDefault(); - NEWSBLUR.about = new NEWSBLUR.About(); + $.modal.close(function() { + NEWSBLUR.about = new NEWSBLUR.About(); + }); }); } diff --git a/media/js/newsblur/reader.js b/media/js/newsblur/reader.js index 1e02dff21..0874c5762 100644 --- a/media/js/newsblur/reader.js +++ b/media/js/newsblur/reader.js @@ -2815,7 +2815,7 @@ this.hide_progress_bar(); } }, - + // ========== // = Events = // ========== diff --git a/media/js/newsblur/reader_classifier.js b/media/js/newsblur/reader_classifier.js index ada5a0f1d..27de068db 100644 --- a/media/js/newsblur/reader_classifier.js +++ b/media/js/newsblur/reader_classifier.js @@ -184,7 +184,6 @@ var classifier = { $.make('br'), $.make('img', { className: 'NB-trainer-bullet', src: NEWSBLUR.Globals.MEDIA_URL + '/img/icons/silk/bullet_green.png'}), ' are stories you like' - ]), $.make('li', [ $.make('img', { src: NEWSBLUR.Globals.MEDIA_URL + '/img/reader/sample_menu.png', style: 'float: right', width: 176, height: 118 }),