Allowing empty in-folder in delete feed and delete folder.

This commit is contained in:
Samuel Clay 2013-08-05 15:30:56 -07:00
parent d6a3df29bf
commit 6162f7026c
2 changed files with 7 additions and 5 deletions

View file

@ -853,12 +853,14 @@ class UserSubscriptionFolders(models.Model):
new_folders = []
for k, folder in enumerate(old_folders):
if isinstance(folder, int):
if (folder == feed_id and (
if (folder == feed_id and in_folder is not None and (
(folder_name != in_folder) or
(folder_name == in_folder and deleted))):
multiples_found = True
logging.user(self.user, "~FB~SBDeleting feed, and a multiple has been found in '%s'" % (folder_name))
if folder == feed_id and (folder_name == in_folder) and not deleted:
if (folder == feed_id and
(folder_name == in_folder or in_folder is None) and
not deleted):
logging.user(self.user, "~FBDelete feed: %s'th item: %s folders/feeds" % (
k, len(old_folders)
))
@ -901,7 +903,7 @@ class UserSubscriptionFolders(models.Model):
feeds_to_delete.remove(folder)
elif isinstance(folder, dict):
for f_k, f_v in folder.items():
if f_k == folder_to_delete and folder_name == in_folder:
if f_k == folder_to_delete and (folder_name == in_folder or in_folder is None):
logging.user(self.user, "~FBDeleting folder '~SB%s~SN' in '%s': %s" % (f_k, folder_name, folder))
deleted_folder = folder
else:

View file

@ -1338,7 +1338,7 @@ def add_folder(request):
@json.json_view
def delete_feed(request):
feed_id = int(request.POST['feed_id'])
in_folder = request.POST.get('in_folder', '')
in_folder = request.POST.get('in_folder', None)
if in_folder == ' ':
in_folder = ""
@ -1379,7 +1379,7 @@ def delete_feed_by_url(request):
@json.json_view
def delete_folder(request):
folder_to_delete = request.POST.get('folder_name') or request.POST.get('folder_to_delete')
in_folder = request.POST.get('in_folder', '')
in_folder = request.POST.get('in_folder', None)
feed_ids_in_folder = [int(f) for f in request.REQUEST.getlist('feed_id') if f]
# Works piss poor with duplicate folder titles, if they are both in the same folder.