diff --git a/clients/android/NewsBlur/build.gradle b/clients/android/NewsBlur/build.gradle index 3040ab719..5e873cc63 100644 --- a/clients/android/NewsBlur/build.gradle +++ b/clients/android/NewsBlur/build.gradle @@ -39,6 +39,7 @@ dependencies { implementation 'com.github.jinatonic.confetti:confetti:1.1.2' implementation 'com.google.android.play:core:1.8.3' implementation "com.google.android.material:material:1.2.1" + implementation "androidx.preference:preference-ktx:1.1.1" } android { diff --git a/clients/android/NewsBlur/res/values/styles.xml b/clients/android/NewsBlur/res/values/styles.xml index 66728d7ce..fddb2bda7 100644 --- a/clients/android/NewsBlur/res/values/styles.xml +++ b/clients/android/NewsBlur/res/values/styles.xml @@ -394,4 +394,22 @@ @color/gray13 + + + + + + + + diff --git a/clients/android/NewsBlur/res/values/theme.xml b/clients/android/NewsBlur/res/values/theme.xml index 3dddcf388..a4760d85c 100644 --- a/clients/android/NewsBlur/res/values/theme.xml +++ b/clients/android/NewsBlur/res/values/theme.xml @@ -48,6 +48,7 @@ @style/selectorOverlayBackgroundText @style/muteicon @color/black + @style/preferenceTheme diff --git a/clients/android/NewsBlur/src/com/newsblur/activity/Settings.java b/clients/android/NewsBlur/src/com/newsblur/activity/Settings.java index 4b2c3ffde..3a10a10d5 100644 --- a/clients/android/NewsBlur/src/com/newsblur/activity/Settings.java +++ b/clients/android/NewsBlur/src/com/newsblur/activity/Settings.java @@ -1,9 +1,9 @@ package com.newsblur.activity; -import androidx.appcompat.app.AppCompatActivity; import android.content.SharedPreferences; import android.os.Bundle; -import android.view.MenuItem; + +import androidx.appcompat.app.AppCompatActivity; import com.newsblur.R; import com.newsblur.fragment.SettingsFragment; @@ -21,8 +21,10 @@ public class Settings extends AppCompatActivity implements SharedPreferences.OnS UIUtils.setCustomActionBar(this, R.drawable.logo, getString(R.string.settings), true); - SettingsFragment fragment = new SettingsFragment(); - getFragmentManager().beginTransaction().replace(android.R.id.content, fragment).commit(); + getSupportFragmentManager() + .beginTransaction() + .replace(android.R.id.content, new SettingsFragment()) + .commit(); SharedPreferences prefs = getSharedPreferences(PrefConstants.PREFERENCES, 0); prefs.registerOnSharedPreferenceChangeListener(this); @@ -30,21 +32,10 @@ public class Settings extends AppCompatActivity implements SharedPreferences.OnS @Override protected void onDestroy() { - super.onDestroy(); - SharedPreferences prefs = getSharedPreferences(PrefConstants.PREFERENCES, 0); prefs.unregisterOnSharedPreferenceChangeListener(this); - } + super.onDestroy(); - @Override - public boolean onOptionsItemSelected(MenuItem item) { - switch (item.getItemId()) { - case android.R.id.home: - finish(); - return true; - default: - return super.onOptionsItemSelected(item); - } } @Override diff --git a/clients/android/NewsBlur/src/com/newsblur/fragment/SettingsFragment.java b/clients/android/NewsBlur/src/com/newsblur/fragment/SettingsFragment.java index 0e676aa1f..883143099 100644 --- a/clients/android/NewsBlur/src/com/newsblur/fragment/SettingsFragment.java +++ b/clients/android/NewsBlur/src/com/newsblur/fragment/SettingsFragment.java @@ -1,20 +1,19 @@ package com.newsblur.fragment; import android.os.Bundle; -import android.preference.PreferenceFragment; -import android.preference.PreferenceManager; + +import androidx.preference.PreferenceFragmentCompat; +import androidx.preference.PreferenceManager; import com.newsblur.R; import com.newsblur.util.PrefConstants; -public class SettingsFragment extends PreferenceFragment { +public class SettingsFragment extends PreferenceFragmentCompat { @Override - public void onCreate(Bundle savedInstanceState) { - super.onCreate(savedInstanceState); + public void onCreatePreferences(Bundle savedInstanceState, String rootKey) { PreferenceManager preferenceManager = getPreferenceManager(); preferenceManager.setSharedPreferencesName(PrefConstants.PREFERENCES); - addPreferencesFromResource(R.xml.activity_settings); + setPreferencesFromResource(R.xml.activity_settings, rootKey); } - -} +} \ No newline at end of file