public-mirrors/NewsBlur
1
0
Fork 0
mirror of https://github.com/samuelclay/NewsBlur.git synced 2025-09-18 21:50:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove pre-recyclerview loader workaround

Browse source
This commit is contained in:
dosiecki 2018-04-27 14:46:47 -07:00
parent b640012ac6
commit 2eb36e0bbe
2 changed files with 0 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
clients/android/NewsBlur/src/com/newsblur/activity/ItemsList.java
View file

@ -381,12 +381,6 @@ public abstract class ItemsList extends NbActivity implements StoryOrderChangedL
@Override @Override
public void finish() { public void finish() {
if (itemSetFragment != null) {
// since v6.0 of Android, the ListView in the fragment likes to crash if the underlying
// dataset changes rapidly as happens when marking-all-read and when the fragment is
// stopping. do a manual hard-stop of the loaders in the fragment before we finish
itemSetFragment.stopLoader();
}
super.finish(); super.finish();
/* /*
* Animate out the list by sliding it to the right and the Main activity in from * Animate out the list by sliding it to the right and the Main activity in from

10
clients/android/NewsBlur/src/com/newsblur/fragment/ItemSetFragment.java
View file

@ -43,7 +43,6 @@ public class ItemSetFragment extends NbFragment implements LoaderManager.LoaderC
private static final String BUNDLE_GRIDSTATE = "gridstate"; private static final String BUNDLE_GRIDSTATE = "gridstate";
protected boolean cursorSeenYet = false; // have we yet seen a valid cursor for our particular feedset? protected boolean cursorSeenYet = false; // have we yet seen a valid cursor for our particular feedset?
private boolean stopLoading = false;
private int itemGridWidthPx = 0; private int itemGridWidthPx = 0;
private int columnCount; private int columnCount;
@ -93,7 +92,6 @@ public class ItemSetFragment extends NbFragment implements LoaderManager.LoaderC
@Override @Override
public void onStart() { public void onStart() {
super.onStart(); super.onStart();
stopLoading = false;
} }
@Override @Override
@ -213,13 +211,6 @@ public class ItemSetFragment extends NbFragment implements LoaderManager.LoaderC
if (gotSome || (totalSeen == null)) triggerSync(); if (gotSome || (totalSeen == null)) triggerSync();
} }
/**
* Signal that all futher cursor loads should be ignored
*/
public void stopLoader() {
stopLoading = true;
}
/** /**
* Indicate that the DB was cleared. * Indicate that the DB was cleared.
*/ */
@ -273,7 +264,6 @@ public class ItemSetFragment extends NbFragment implements LoaderManager.LoaderC
@Override @Override
public synchronized void onLoadFinished(Loader<Cursor> loader, Cursor cursor) { public synchronized void onLoadFinished(Loader<Cursor> loader, Cursor cursor) {
if (stopLoading) return;
if (cursor != null) { if (cursor != null) {
if (! FeedUtils.dbHelper.isFeedSetReady(getFeedSet())) { if (! FeedUtils.dbHelper.isFeedSetReady(getFeedSet())) {
// the DB hasn't caught up yet from the last story list; don't display stale stories. // the DB hasn't caught up yet from the last story list; don't display stale stories.