public-mirrors/NewsBlur
1
0
Fork 0
mirror of https://github.com/samuelclay/NewsBlur.git synced 2025-09-18 21:50:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Restore error messaging from failed async API calls.

Browse source
This commit is contained in:
dosiecki 2015-08-31 19:55:36 -07:00
parent bc88ca7ce9
commit 2cf7d8d7c1
3 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
clients/android/NewsBlur/src/com/newsblur/activity/ItemsList.java
View file

@ -9,7 +9,6 @@ import android.view.MenuItem;
import android.view.View;
import android.view.Window;
import android.widget.TextView;
import android.widget.Toast;
import com.newsblur.R;
import com.newsblur.fragment.DefaultFeedViewDialogFragment;

14
clients/android/NewsBlur/src/com/newsblur/activity/NbActivity.java
View file

@ -4,10 +4,12 @@ import android.app.Activity;
import android.content.Intent;
import android.os.Bundle;
import android.util.Log;
import android.widget.Toast;
import com.newsblur.service.NBSyncService;
import com.newsblur.util.AppConstants;
import com.newsblur.util.PrefsUtils;
import com.newsblur.util.UIUtils;
import java.util.ArrayList;
@ -125,6 +127,18 @@ public class NbActivity extends Activity {
}
}
public static void toastError(final String message) {
synchronized (AllActivities) {
for (final NbActivity activity : AllActivities) {
activity.runOnUiThread(new Runnable() {
public void run() {
UIUtils.safeToast(activity, message, Toast.LENGTH_SHORT);
}
});
}
}
}
/**
* Gets the number of active/foreground NB activities. Used by the sync service to
* determine if the app is active so we can honour user requests not to run in

2
clients/android/NewsBlur/src/com/newsblur/service/NBSyncService.java
View file

@ -340,6 +340,8 @@ public class NBSyncService extends Service {
} else if (response.isError()) {
Log.e(this.getClass().getName(), "Discarding reading action with user error.");
dbHelper.clearAction(id);
String message = response.getErrorMessage(null);
if (message != null) NbActivity.toastError(message);
} else {
// success!
dbHelper.clearAction(id);