From 610855b104d015a7c523e1ef1f19f397420d4ba2 Mon Sep 17 00:00:00 2001 From: David Sinclair Date: Sat, 28 Mar 2020 14:13:14 -0700 Subject: [PATCH 1/2] Xcode 11.4 tweaks --- clients/ios/Classes/EventWindow.m | 2 ++ clients/ios/NewsBlur.xcodeproj/project.pbxproj | 6 +----- .../xcshareddata/xcschemes/NewsBlur.xcscheme | 2 +- .../xcshareddata/xcschemes/Share Extension.xcscheme | 2 +- .../xcschemes/Story Notification Service Extension.xcscheme | 2 +- .../xcshareddata/xcschemes/Widget Extension.xcscheme | 2 +- 6 files changed, 7 insertions(+), 9 deletions(-) diff --git a/clients/ios/Classes/EventWindow.m b/clients/ios/Classes/EventWindow.m index 8ebaf0659..c40ea368c 100644 --- a/clients/ios/Classes/EventWindow.m +++ b/clients/ios/Classes/EventWindow.m @@ -77,6 +77,8 @@ [contextualMenuTimer invalidate]; contextualMenuTimer = nil; break; + default: + break; } } else { // Multiple fingers are touching the screen unmoved = NO; diff --git a/clients/ios/NewsBlur.xcodeproj/project.pbxproj b/clients/ios/NewsBlur.xcodeproj/project.pbxproj index 917a132d3..8565dd3c5 100755 --- a/clients/ios/NewsBlur.xcodeproj/project.pbxproj +++ b/clients/ios/NewsBlur.xcodeproj/project.pbxproj @@ -315,7 +315,6 @@ FF22FE7316E554FD0046165A /* barbutton_sendto@2x.png in Resources */ = {isa = PBXBuildFile; fileRef = FF22FE7116E554FD0046165A /* barbutton_sendto@2x.png */; }; FF22FE7616E557D80046165A /* toolbar_tall_background.png in Resources */ = {isa = PBXBuildFile; fileRef = FF22FE7416E557D80046165A /* toolbar_tall_background.png */; }; FF22FE7716E557D80046165A /* toolbar_tall_background@2x.png in Resources */ = {isa = PBXBuildFile; fileRef = FF22FE7516E557D80046165A /* toolbar_tall_background@2x.png */; }; - FF26125418C00FEC0055FF4D /* AddressBook.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FF26125318C00FEC0055FF4D /* AddressBook.framework */; }; FF265F12187B6D4F0080C332 /* fitvid.js in Resources */ = {isa = PBXBuildFile; fileRef = FF265F10187B6B230080C332 /* fitvid.js */; }; FF2924E51E932D2900FCFA63 /* PINCache.m in Sources */ = {isa = PBXBuildFile; fileRef = FF2924DF1E932D2900FCFA63 /* PINCache.m */; }; FF2924E61E932D2900FCFA63 /* PINDiskCache.m in Sources */ = {isa = PBXBuildFile; fileRef = FF2924E21E932D2900FCFA63 /* PINDiskCache.m */; }; @@ -333,7 +332,6 @@ FF2D8B351487250C00057B80 /* MessageUI.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FF2D8B341487250C00057B80 /* MessageUI.framework */; }; FF2D8C6C1487F05100057B80 /* Twitter.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FF2D8C6B1487F05100057B80 /* Twitter.framework */; settings = {ATTRIBUTES = (Weak, ); }; }; FF2D8CE514893BC000057B80 /* MoveSiteViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = FF2D8CE314893BBF00057B80 /* MoveSiteViewController.m */; }; - FF308A7B18C01014009F986A /* AssetsLibrary.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FF308A7A18C01014009F986A /* AssetsLibrary.framework */; }; FF308A7D18C01025009F986A /* CoreMotion.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FF308A7C18C01025009F986A /* CoreMotion.framework */; }; FF308A7F18C01037009F986A /* CoreLocation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FF308A7E18C01037009F986A /* CoreLocation.framework */; }; FF308A8118C01043009F986A /* MediaPlayer.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FF308A8018C01043009F986A /* MediaPlayer.framework */; }; @@ -1505,8 +1503,6 @@ FF308A7F18C01037009F986A /* CoreLocation.framework in Frameworks */, FF83FF011FB51628008DAC0F /* StoreKit.framework in Frameworks */, FF308A7D18C01025009F986A /* CoreMotion.framework in Frameworks */, - FF308A7B18C01014009F986A /* AssetsLibrary.framework in Frameworks */, - FF26125418C00FEC0055FF4D /* AddressBook.framework in Frameworks */, FF468E3817FCFB970080325C /* AVFoundation.framework in Frameworks */, 78095E45128EF37E00230C8E /* SystemConfiguration.framework in Frameworks */, FF4EE9A4175EC9CF005891B5 /* libsqlite3.dylib in Frameworks */, @@ -2836,7 +2832,7 @@ isa = PBXProject; attributes = { LastSwiftUpdateCheck = 1120; - LastUpgradeCheck = 1130; + LastUpgradeCheck = 1140; ORGANIZATIONNAME = NewsBlur; TargetAttributes = { 1749390F1C251BFE003D98AA = { diff --git a/clients/ios/NewsBlur.xcodeproj/xcshareddata/xcschemes/NewsBlur.xcscheme b/clients/ios/NewsBlur.xcodeproj/xcshareddata/xcschemes/NewsBlur.xcscheme index 19b8c2c57..49dd63ead 100644 --- a/clients/ios/NewsBlur.xcodeproj/xcshareddata/xcschemes/NewsBlur.xcscheme +++ b/clients/ios/NewsBlur.xcodeproj/xcshareddata/xcschemes/NewsBlur.xcscheme @@ -1,6 +1,6 @@ Date: Sat, 28 Mar 2020 14:31:50 -0700 Subject: [PATCH 2/2] #1292 (dark mode FTUX) - Fixed; only affected iPad in dark mode, so probably not too egregious. --- .../Classes/LoginViewController~ipad.xib | 68 ++++++++++--------- 1 file changed, 36 insertions(+), 32 deletions(-) diff --git a/clients/ios/Resources-iPad/Classes/LoginViewController~ipad.xib b/clients/ios/Resources-iPad/Classes/LoginViewController~ipad.xib index ee7013ef5..ff290cb7f 100644 --- a/clients/ios/Resources-iPad/Classes/LoginViewController~ipad.xib +++ b/clients/ios/Resources-iPad/Classes/LoginViewController~ipad.xib @@ -1,11 +1,9 @@ - - - - + + - + @@ -50,19 +48,19 @@ - + - + - + - - + - + - -