diff --git a/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/FeedChooser.java b/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/FeedChooser.java index 9f4a0cc4a..7a9167521 100644 --- a/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/FeedChooser.java +++ b/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/FeedChooser.java @@ -101,44 +101,44 @@ abstract public class FeedChooser extends NbActivity { @Override public boolean onOptionsItemSelected(MenuItem item) { - switch (item.getItemId()) { - case android.R.id.home: - finish(); - return true; - case R.id.menu_sort_order_ascending: - replaceListOrderFilter(ListOrderFilter.ASCENDING); - return true; - case R.id.menu_sort_order_descending: - replaceListOrderFilter(ListOrderFilter.DESCENDING); - return true; - case R.id.menu_sort_by_name: - replaceFeedOrderFilter(FeedOrderFilter.NAME); - return true; - case R.id.menu_sort_by_subs: - replaceFeedOrderFilter(FeedOrderFilter.SUBSCRIBERS); - return true; - case R.id.menu_sort_by_recent_story: - replaceFeedOrderFilter(FeedOrderFilter.RECENT_STORY); - return true; - case R.id.menu_sort_by_stories_month: - replaceFeedOrderFilter(FeedOrderFilter.STORIES_MONTH); - return true; - case R.id.menu_sort_by_number_opens: - replaceFeedOrderFilter(FeedOrderFilter.OPENS); - return true; - case R.id.menu_folder_view_nested: - replaceFolderView(FolderViewFilter.NESTED); - return true; - case R.id.menu_folder_view_flat: - replaceFolderView(FolderViewFilter.FLAT); - return true; - case R.id.menu_widget_background_default: - setWidgetBackground(WidgetBackground.DEFAULT); - return true; - case R.id.menu_widget_background_transparent: - setWidgetBackground(WidgetBackground.TRANSPARENT); - default: - return super.onOptionsItemSelected(item); + if (item.getItemId() == android.R.id.home) { + finish(); + return true; + } else if (item.getItemId() == R.id.menu_sort_order_ascending) { + replaceListOrderFilter(ListOrderFilter.ASCENDING); + return true; + } else if (item.getItemId() == R.id.menu_sort_order_descending) { + replaceListOrderFilter(ListOrderFilter.DESCENDING); + return true; + } else if (item.getItemId() == R.id.menu_sort_by_name) { + replaceFeedOrderFilter(FeedOrderFilter.NAME); + return true; + } else if (item.getItemId() == R.id.menu_sort_by_subs) { + replaceFeedOrderFilter(FeedOrderFilter.SUBSCRIBERS); + return true; + } else if (item.getItemId() == R.id.menu_sort_by_recent_story) { + replaceFeedOrderFilter(FeedOrderFilter.RECENT_STORY); + return true; + } else if (item.getItemId() == R.id.menu_sort_by_stories_month) { + replaceFeedOrderFilter(FeedOrderFilter.STORIES_MONTH); + return true; + } else if (item.getItemId() == R.id.menu_sort_by_number_opens) { + replaceFeedOrderFilter(FeedOrderFilter.OPENS); + return true; + } else if (item.getItemId() == R.id.menu_folder_view_nested) { + replaceFolderView(FolderViewFilter.NESTED); + return true; + } else if (item.getItemId() == R.id.menu_folder_view_flat) { + replaceFolderView(FolderViewFilter.FLAT); + return true; + } else if (item.getItemId() == R.id.menu_widget_background_default) { + setWidgetBackground(WidgetBackground.DEFAULT); + return true; + } else if (item.getItemId() == R.id.menu_widget_background_transparent) { + setWidgetBackground(WidgetBackground.TRANSPARENT); + return true; + } else { + return super.onOptionsItemSelected(item); } } diff --git a/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/MuteConfig.java b/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/MuteConfig.java index 5c9677e52..3d3889632 100644 --- a/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/MuteConfig.java +++ b/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/MuteConfig.java @@ -59,15 +59,14 @@ public class MuteConfig extends FeedChooser implements MuteConfigAdapter.FeedSta @Override public boolean onOptionsItemSelected(MenuItem item) { - switch (item.getItemId()) { - case R.id.menu_mute_all: - setFeedsState(true); - return true; - case R.id.menu_mute_none: - setFeedsState(false); - return true; - default: - return super.onOptionsItemSelected(item); + if (item.getItemId() == R.id.menu_mute_all) { + setFeedsState(true); + return true; + } else if (item.getItemId() == R.id.menu_mute_none) { + setFeedsState(false); + return true; + } else { + return super.onOptionsItemSelected(item); } } diff --git a/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/WidgetConfig.java b/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/WidgetConfig.java index 84d886419..91fb88b72 100644 --- a/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/WidgetConfig.java +++ b/clients/android/NewsBlur/app/src/main/java/com/newsblur/activity/WidgetConfig.java @@ -62,15 +62,14 @@ public class WidgetConfig extends FeedChooser { @Override public boolean onOptionsItemSelected(MenuItem item) { - switch (item.getItemId()) { - case R.id.menu_select_all: - selectAllFeeds(); - return true; - case R.id.menu_select_none: - replaceWidgetFeedIds(Collections.emptySet()); - return true; - default: - return super.onOptionsItemSelected(item); + if (item.getItemId() == R.id.menu_select_all) { + selectAllFeeds(); + return true; + } else if (item.getItemId() == R.id.menu_select_none) { + replaceWidgetFeedIds(Collections.emptySet()); + return true; + } else { + return super.onOptionsItemSelected(item); } } diff --git a/clients/android/NewsBlur/app/src/main/java/com/newsblur/database/StoryViewAdapter.java b/clients/android/NewsBlur/app/src/main/java/com/newsblur/database/StoryViewAdapter.java index acac278dc..f3ebc2473 100644 --- a/clients/android/NewsBlur/app/src/main/java/com/newsblur/database/StoryViewAdapter.java +++ b/clients/android/NewsBlur/app/src/main/java/com/newsblur/database/StoryViewAdapter.java @@ -413,52 +413,42 @@ public class StoryViewAdapter extends RecyclerView.Adapter