From 146f9392ff7bd26dcbc20680c05e543d2dae3d3e Mon Sep 17 00:00:00 2001 From: Samuel Clay Date: Wed, 24 Jul 2013 17:25:12 -0700 Subject: [PATCH] Fixing JS exception on missing users. --- media/js/newsblur/views/story_comments_view.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/media/js/newsblur/views/story_comments_view.js b/media/js/newsblur/views/story_comments_view.js index b50cb2202..2f1ede47a 100644 --- a/media/js/newsblur/views/story_comments_view.js +++ b/media/js/newsblur/views/story_comments_view.js @@ -46,12 +46,16 @@ NEWSBLUR.Views.StoryCommentsView = Backbone.View.extend({ var comment_user_ids = this.model.get('comment_user_ids'); _.each(this.model.get('shared_by_friends'), function(user_id) { if (_.contains(comment_user_ids, user_id)) return; - var $thumb = NEWSBLUR.Views.ProfileThumb.create(user_id).render().el; + var profile_thumb = NEWSBLUR.Views.ProfileThumb.create(user_id); + if (!profile_thumb) return; + var $thumb = profile_thumb.render().el; $shares_friends.append($thumb); }); _.each(this.model.get('shared_by_public'), function(user_id) { if (_.contains(comment_user_ids, user_id)) return; - var $thumb = NEWSBLUR.Views.ProfileThumb.create(user_id).render().el; + var profile_thumb = NEWSBLUR.Views.ProfileThumb.create(user_id); + if (!profile_thumb) return; + var $thumb = profile_thumb.render().el; $shares_public.append($thumb); }); },