iOS: fixed remaining Xcode 8 warnings

Now zero warnings on build. Ah, so much cleaner.

clients/ios/ASI/ASIAuthenticationDialog.m

@@ -145,7 +145,7 @@ static const NSUInteger kDomainSection = 1;
 	CGRect f = [[UIScreen mainScreen] applicationFrame];
 
 	// Swap the frame height and width if necessary
- 	if (UIDeviceOrientationIsLandscape(o)) {
+ 	if (UIInterfaceOrientationIsLandscape(o)) {
 		CGFloat t;
 		t = f.size.width;
 		f.size.width = f.size.height;
@@ -268,7 +268,7 @@ static const NSUInteger kDomainSection = 1;
 {
 	UINavigationBar *navigationBar = [[[self view] subviews] objectAtIndex:0];
 	UINavigationItem *navItem = [[navigationBar items] objectAtIndex:0];
-	if (UIInterfaceOrientationIsPortrait([[UIDevice currentDevice] orientation])) {
+	if (UIDeviceOrientationIsPortrait([[UIDevice currentDevice] orientation])) {
 		// Setup the title
 		if ([self type] == ASIProxyAuthenticationType) {
 			[navItem setPrompt:@"Login to this secure proxy server."];

clients/ios/ASI/ASIDataCompressor.m

@@ -98,7 +98,7 @@
 			if (err) {
 				*err = [[self class] deflateErrorWithCode:status];
 			}
-			return NO;
+			return nil;
 		}
 	}
 

clients/ios/Classes/AddSiteViewController.m

@@ -423,6 +423,10 @@
                 cell = (AddSiteAutocompleteCell *)oneObject;
             }
         }
+        
+        if (cell == nil) {
+            cell = [AddSiteAutocompleteCell new];
+        }
 	}
     
     NSDictionary *result = [self.autocompleteResults objectAtIndex:indexPath.row];

clients/ios/Other Sources/AFNetworking/AFNetworkReachabilityManager.m

@@ -131,7 +131,9 @@ static void AFNetworkReachabilityReleaseCallback(const void *info) {
 
     AFNetworkReachabilityManager *manager = [[self alloc] initWithReachability:reachability];
     manager.networkReachabilityAssociation = AFNetworkReachabilityForName;
-
+    
+    CFRelease(reachability);
+    
     return manager;
 }
 
@@ -140,7 +142,9 @@ static void AFNetworkReachabilityReleaseCallback(const void *info) {
 
     AFNetworkReachabilityManager *manager = [[self alloc] initWithReachability:reachability];
     manager.networkReachabilityAssociation = AFNetworkReachabilityForAddress;
-
+    
+    CFRelease(reachability);
+    
     return manager;
 }
 
@@ -150,7 +154,7 @@ static void AFNetworkReachabilityReleaseCallback(const void *info) {
         return nil;
     }
 
-    self.networkReachability = CFBridgingRelease(reachability);
+    _networkReachability = CFRetain(reachability);
     self.networkReachabilityStatus = AFNetworkReachabilityStatusUnknown;
 
     return self;

clients/ios/Other Sources/AFNetworking/AFURLSessionManager.m

@@ -700,7 +700,11 @@ static NSString * const AFNSURLSessionTaskDidSuspendNotification = @"com.alamofi
             uploadTask = [self.session uploadTaskWithRequest:request fromFile:fileURL];
         }
     }
-
+    
+    if (!uploadTask) {
+        uploadTask = [self.session uploadTaskWithRequest:request fromFile:fileURL];
+    }
+    
     [self addDelegateForUploadTask:uploadTask progress:progress completionHandler:completionHandler];
 
     return uploadTask;

clients/ios/Other Sources/Base64.m

@@ -67,8 +67,13 @@ static const char encodingTable[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopq
             bytes[length++] = (buffer[2] << 6) | buffer[3];
     }
     
-    realloc(bytes, length);
-    return [NSData dataWithBytesNoCopy:bytes length:length];
+    char *temp = realloc(bytes, length);
+    
+    if (temp) {
+        return [NSData dataWithBytesNoCopy:bytes length:length];
+    } else {
+        return nil;
+    }
 }
 
 - (NSString *)base64Encoding;

clients/ios/Other Sources/Reachability/Reachability.m

@@ -99,7 +99,9 @@ static void TMReachabilityCallback(SCNetworkReachabilityRef target, SCNetworkRea
     if (ref) 
     {
         id reachability = [[self alloc] initWithReachabilityRef:ref];
-
+        
+        CFRelease(ref);
+        
         return reachability;
     }
     
@@ -113,6 +115,8 @@ static void TMReachabilityCallback(SCNetworkReachabilityRef target, SCNetworkRea
     {
         id reachability = [[self alloc] initWithReachabilityRef:ref];
         
+        CFRelease(ref);
+        
         return reachability;
     }
     
@@ -150,7 +154,7 @@ static void TMReachabilityCallback(SCNetworkReachabilityRef target, SCNetworkRea
     if (self != nil) 
     {
         self.reachableOnWWAN = YES;
-        self.reachabilityRef = ref;
+        _reachabilityRef = CFRetain(ref);
 
         // We need to create a serial queue.
         // We allocate this once for the lifetime of the notifier.

clients/ios/Other Sources/SloppySwiper/SloppySwiper.m

@@ -42,6 +42,8 @@
 
 - (void)awakeFromNib
 {
+    [super awakeFromNib];
+    
     [self commonInit];
 }