Fixing scroll/paging bug where the wrong story would be selected. Technically it's not fixed, but the indicator is now always present, so you know why it's happening. Thanks to @afita for the thorough investigation.

This commit is contained in:
Samuel Clay 2012-07-12 13:43:39 -07:00
parent febd0ae0a3
commit b1bedb42d4
2 changed files with 13 additions and 6 deletions

View file

@ -643,6 +643,9 @@
left:'+=0'
}, 230, {queue: false});
}
this.show_mouse_indicator();
// _.delay(_.bind(this.hide_mouse_indicator, this), 350);
},
find_story_with_action_preference_on_open_feed: function() {
@ -2110,6 +2113,7 @@
}
}
this.setup_mousemove_on_views();
},
switch_taskbar_view_direction: function(direction) {
@ -3497,12 +3501,13 @@
setup_mousemove_on_views: function() {
this.hide_mouse_indicator();
this.$s.$content_pane
.unbind('mouseleave.reader')
.bind('mouseleave.reader', $.rescope(this.hide_mouse_indicator, this));
this.$s.$content_pane
.unbind('mouseenter.reader')
.bind('mouseenter.reader', $.rescope(this.show_mouse_indicator, this));
if (this.story_view == 'story' ||
this.flags['feed_view_showing_story_view']) {
// this.hide_mouse_indicator();
} else {
_.delay(_.bind(this.show_mouse_indicator, this), 350);
}
},
hide_mouse_indicator: function() {
@ -3522,6 +3527,7 @@
show_mouse_indicator: function() {
var self = this;
if (this.flags['mouse_indicator_hidden']) {
this.flags['mouse_indicator_hidden'] = false;
this.$s.$mouse_indicator.animate({'opacity': 1, 'left': 0}, {

View file

@ -337,6 +337,7 @@ NEWSBLUR.Views.OriginalTabView = Backbone.View.extend({
models = NEWSBLUR.assets.stories;
}
if (!models.length) return;
if (NEWSBLUR.reader.story_view != 'page') return;
this.flags['iframe_fetching_story_locations'] = false;
this.flags['iframe_story_locations_fetched'] = false;