public-mirrors/NewsBlur-viq
1
0
Fork 0
mirror of https://github.com/viq/NewsBlur.git synced 2025-09-18 21:43:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Exponential speed-ups in determining story positions in the feed view pane. Thank you closures.

Browse source
This commit is contained in:
Samuel Clay 2010-01-17 18:18:51 +00:00
parent b16360462e
commit 6451cade96
1 changed files with 53 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
media/js/newsblur/reader.js
View file

@ -446,8 +446,18 @@
}
for (s in stories) {
var story = stories[s];
this.load_story_feed_view_entry($stories, stories, 0, 0);
var $endbar = $.make('div', { className: 'NB-feed-story-endbar' });
$stories.append($endbar);
},
load_story_feed_view_entry: function($stories, stories, story_index, timeout) {
var self = this;
if (stories[story_index]) {
setTimeout(function() {
var story = stories[story_index];
var $story = $.make('li', { className: 'NB-feed-story' }, [
$.make('div', { className: 'NB-feed-story-header' }, [
@ -459,11 +469,32 @@
]),
$.make('div', { className: 'NB-feed-story-content' }, story.story_content)
]).data('story', story.id);
$stories.append($story);
self.cache.feed_view_stories[story.id] = $story;
var image_count = $('img', $story).length;
if (!image_count) {
self.determine_feed_view_story_position($story, story);
self.load_story_feed_view_entry($stories, stories, story_index+1, 0);
} else {
(function(image_count, $story, story) {
$('img', $story).load(function() {
// NEWSBLUR.log(['Loaded image', $story, story, image_count]);
if (image_count == 1) {
NEWSBLUR.log(['Determining story position', $story, story]);
self.determine_feed_view_story_position($story, story);
self.load_story_feed_view_entry($stories, stories, story_index+1, 500);
} else {
image_count--;
}
});
})(image_count, $story, story);
}
}, timeout);
}
},
this.cache.feed_view_stories[story.id] = $story;
determine_feed_view_story_position: function($story, story) {
var position_original = parseInt($story.offset().top, 10);
var position_offset = parseInt($story.offsetParent().scrollTop(), 10);
var position = position_original + position_offset;
@ -471,11 +502,6 @@
this.cache.feed_view_story_positions_keys.push(position);
this.cache.feed_view_story_positions_keys.sort(function(a,b) {return a>b;});
// NEWSBLUR.log(['Positioning story', position, $story, story, this.cache.feed_view_story_positions_keys]);
}
var $endbar = $.make('div', { className: 'NB-feed-story-endbar' });
$stories.append($endbar);
},
show_feed_page_contents: function(feed_id) {
@ -810,7 +836,7 @@
NEWSBLUR.log(['Found '+(s-2)+' stories on page.', self.cache.iframe_stories]);
self.flags.story_frame_prefetched = true;
}
}, 100);
}, 200);
}
},