Commit graph

25 commits

Author SHA1 Message Date
James Norton
741ed593b2 Fix height setting in Ellipse initialization 2019-03-07 10:44:43 -05:00
Jean Whitmore
73a6c2400b Fixed CurvedArrow constructor by moving get_length() to base class.
I moved get_length() from the Line class to the shared base class,
TipableVMobject.

TESTED

python3 -m manim manim_tutorial_P37.py MoreShapes -pl
2019-03-03 07:53:15 -06:00
Jean Whitmore
61dbad5edd Revert "Reverted Cleaned Up Arrow Implementation (commit d489b5df5c77...)"
Undoing my revert of another commit because I found a fix.

This reverts commit cd29ff6e0d.
2019-03-03 07:42:00 -06:00
Jean Whitmore
cd29ff6e0d Reverted Cleaned Up Arrow Implementation (commit d489b5df5c77...) 2019-02-24 11:57:02 -06:00
jeanimal
2d552e0aa4
Fix Ellipse constructor: 'width' is not defined
Constructing an ellipse before gave the error "name 'width' is not defined"

I got this error when running the tutorial at https://github.com/zimmermant/manim_tutorial/blob/master/manim_tutorial_P37.py.

python3 -m manim manim_tutorial_P37.py MoreShapes -pl

Traceback (most recent call last):
  File "/Users/jeanwhitmore/Code/python3/manim/manimlib/extract_scene.py", line 153, in main
    scene = SceneClass(**scene_kwargs)
  File "/Users/jeanwhitmore/Code/python3/manim/manimlib/scene/scene.py", line 52, in __init__
    self.construct()
  File "manim_tutorial_P37.py", line 33, in construct
    ellipse=Ellipse(width=3, height=1, color=RED)
  File "/Users/jeanwhitmore/Code/python3/manim/manimlib/mobject/geometry.py", line 319, in __init__
    self.set_width(width, stretch=True)
NameError: name 'width' is not defined

After this fix, the Ellipse can be constructed and the animation is generated.

(Another shape is still broken, and I will try to fix that, too.)
2019-02-17 21:34:40 -06:00
Grant Sanderson
18de4c5404 Make it sound that Polygon.round_corners leaves it with evenly distributed anchors 2019-02-15 15:16:02 -08:00
Grant Sanderson
a6dd906983 Remove commented out Arrow tip_length default 2019-02-15 11:48:23 -08:00
Grant Sanderson
84b07bc347 Fixed Polygon.round_corners bug 2019-02-07 22:25:09 -08:00
Grant Sanderson
2449f3a284 Remove Grid 2019-02-07 21:59:32 -08:00
Grant Sanderson
5b5415cc3e Added round_corners method to Polygon 2019-02-07 21:57:40 -08:00
Grant Sanderson
7a488702e4 Changed Rectangle implementation 2019-02-07 21:24:00 -08:00
Grant Sanderson
d489b5df5c Cleaned up Arrow implementation 2019-02-07 21:14:43 -08:00
Grant Sanderson
0a65ee6725 Getting rid of use_rectangular_stem for Arrow 2019-02-07 17:53:11 -08:00
Grant Sanderson
9d132ed5e5 Cleaned up implementation of DashedLine 2019-02-07 15:41:54 -08:00
Grant Sanderson
0ecac2bfb4 Factored out Line.get_start and Line.get_end to be more general Mobject methods 2019-02-07 14:52:40 -08:00
Grant Sanderson
ce2b508e10 Cleaning up Line 2019-02-07 10:59:04 -08:00
Grant Sanderson
ef7b2919d2 Clean up Sector classes 2019-02-07 10:12:42 -08:00
Grant Sanderson
aa3d9e1a49 Few updates to Arc and Circle 2019-02-07 09:26:18 -08:00
Grant Sanderson
24d6113bba Get rid of propagate_style_to_family, since it is basically always true 2019-02-06 16:25:03 -08:00
Grant Sanderson
d695e2cc0b Made Rectangle a Polygon 2019-02-05 15:24:51 -08:00
Grant Sanderson
eaf25ff34b Changing the way VMobject handles its internal bezier curves so as to eliminate the need for sup_paths 2019-02-05 11:02:15 -08:00
Grant Sanderson
0212fa27e7 Remove commented out old implementation of put_start_and_end_on 2019-02-03 12:10:55 -08:00
Grant Sanderson
e2e6fad114 Add Circle.get_point_from_angle, and arc_center config variable for arc 2019-01-17 14:10:52 -08:00
Grant Sanderson
e63074a72e 2*np.pi -> TAU. Because why not? 2019-01-16 11:09:16 -08:00
Devin Neal
3543a750ba move library code into manimlib, replace relative imports with absolute imports 2018-12-26 20:57:01 -08:00
Renamed from mobject/geometry.py (Browse further)