public-mirrors/3b1b-manim
1
0
Fork 0
mirror of https://github.com/3b1b/manim.git synced 2025-08-05 16:49:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Give unit_normal refreshing the same behavior as triangulation

Browse source 
That is, don't actually compute it until it needs to be. This is necessary so that VMobject.append_points can refresh both of those, without effecting SVG initialization.
This commit is contained in:
Grant Sanderson 2022-12-19 14:41:06 -08:00
parent 4632228cac
commit f158d3e751
1 changed files with 15 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
manimlib/mobject/types/vectorized_mobject.py
View file

@ -100,6 +100,7 @@ class VMobject(Mobject):
self.flat_stroke = flat_stroke self.flat_stroke = flat_stroke
self.needs_new_triangulation = True self.needs_new_triangulation = True
self.needs_new_unit_normal = True
self.triangulation = np.zeros(0, dtype='i4') self.triangulation = np.zeros(0, dtype='i4')
super().__init__(**kwargs) super().__init__(**kwargs)
@ -114,7 +115,7 @@ class VMobject(Mobject):
"fill_rgba": np.zeros((1, 4)), "fill_rgba": np.zeros((1, 4)),
"stroke_rgba": np.zeros((1, 4)), "stroke_rgba": np.zeros((1, 4)),
"stroke_width": np.zeros((1, 1)), "stroke_width": np.zeros((1, 1)),
"unit_normal": np.zeros((1, 3)) "unit_normal": np.array(OUT, ndmin=2),
}) })
# These are here just to make type checkers happy # These are here just to make type checkers happy
@ -771,7 +772,7 @@ class VMobject(Mobject):
]) ])
def get_unit_normal(self, recompute: bool = False) -> Vect3: def get_unit_normal(self, recompute: bool = False) -> Vect3:
if not recompute: if not self.needs_new_unit_normal and not recompute:
return self.data["unit_normal"][0] return self.data["unit_normal"][0]
if self.get_num_points() < 3: if self.get_num_points() < 3:
@ -788,17 +789,12 @@ class VMobject(Mobject):
points[2] - points[1], points[2] - points[1],
) )
self.data["unit_normal"][:] = normal self.data["unit_normal"][:] = normal
self.needs_new_unit_normal = False
return normal return normal
def refresh_unit_normal(self): def refresh_unit_normal(self):
for mob in self.get_family(): for mob in self.get_family():
mob.get_unit_normal(recompute=True) mob.needs_new_unit_normal = True
return self
def reverse_points(self):
super().reverse_points()
self.refresh_unit_normal()
self.refresh_triangulation()
return self return self
# Alignment # Alignment
@ -1030,6 +1026,16 @@ class VMobject(Mobject):
super().set_points(points) super().set_points(points)
return self return self
@triggers_refreshed_triangulation
def append_points(self, points: Vect3Array):
super().append_points(points)
return self
@triggers_refreshed_triangulation
def reverse_points(self):
super().reverse_points()
return self
@triggers_refreshed_triangulation @triggers_refreshed_triangulation
def set_data(self, data: dict): def set_data(self, data: dict):
super().set_data(data) super().set_data(data)