From 5cc30df2acea38763962a713ba76c6706a9681db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=B9=A4=E7=BF=94=E4=B8=87=E9=87=8C?= <44120331+TonyCrane@users.noreply.github.com> Date: Mon, 1 Feb 2021 22:55:40 +0800 Subject: [PATCH 1/7] change 0 to 0.0 in quadratic_bezier_stroke/geom.glsl --- manimlib/shaders/quadratic_bezier_stroke/geom.glsl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/manimlib/shaders/quadratic_bezier_stroke/geom.glsl b/manimlib/shaders/quadratic_bezier_stroke/geom.glsl index ffb4e8eb..f9cfe303 100644 --- a/manimlib/shaders/quadratic_bezier_stroke/geom.glsl +++ b/manimlib/shaders/quadratic_bezier_stroke/geom.glsl @@ -66,7 +66,7 @@ void flatten_points(in vec3[3] points, out vec2[3] flat_points){ float angle_between_vectors(vec2 v1, vec2 v2){ float v1_norm = length(v1); float v2_norm = length(v2); - if(v1_norm == 0 || v2_norm == 0) return 0; + if(v1_norm == 0 || v2_norm == 0) return 0.0; float dp = dot(v1, v2) / (v1_norm * v2_norm); float angle = acos(clamp(dp, -1.0, 1.0)); float sn = sign(cross2d(v1, v2)); @@ -269,4 +269,4 @@ void main() { EmitVertex(); } EndPrimitive(); -} \ No newline at end of file +} From 82eb0ae5beb8a93eaccd81d24cd1dac0d9bf07b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=B9=A4=E7=BF=94=E4=B8=87=E9=87=8C?= <44120331+TonyCrane@users.noreply.github.com> Date: Mon, 1 Feb 2021 22:56:03 +0800 Subject: [PATCH 2/7] change 0 to 0.0 in quadratic_bezier_fill/frag.glsl --- manimlib/shaders/quadratic_bezier_fill/frag.glsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manimlib/shaders/quadratic_bezier_fill/frag.glsl b/manimlib/shaders/quadratic_bezier_fill/frag.glsl index c16c167e..b2a1c82a 100644 --- a/manimlib/shaders/quadratic_bezier_fill/frag.glsl +++ b/manimlib/shaders/quadratic_bezier_fill/frag.glsl @@ -51,7 +51,7 @@ float sdf(){ float sgn = orientation * sign(v2); float Fp = (p.x * p.x - p.y); if(sgn * Fp < 0){ - return 0; + return 0.0; }else{ return min_dist_to_curve(uv_coords, uv_b2, bezier_degree); } From 55e8d3bc552a0859a06eeebe2e592dfe6c9b5811 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=B9=A4=E7=BF=94=E4=B8=87=E9=87=8C?= <44120331+TonyCrane@users.noreply.github.com> Date: Tue, 2 Feb 2021 16:31:57 +0800 Subject: [PATCH 3/7] Update issue templates --- .github/ISSUE_TEMPLATE/bug_report.md | 20 +++++++++++++++++++ .github/ISSUE_TEMPLATE/error-when-using.md | 23 ++++++++++++++++++++++ 2 files changed, 43 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/error-when-using.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..bad3125e --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,20 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: bug +assignees: '' + +--- + +### Describe the bug + + +**Code**: + + +**Wrong display or Error traceback**: + + +### Additional context + diff --git a/.github/ISSUE_TEMPLATE/error-when-using.md b/.github/ISSUE_TEMPLATE/error-when-using.md new file mode 100644 index 00000000..0686dfd3 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/error-when-using.md @@ -0,0 +1,23 @@ +--- +name: Error when using +about: The error you encountered while using manim +title: '' +labels: '' +assignees: '' + +--- + +### Describe the error + + +### Code and Error +**Code**: + + +**Error**: + + +### Environment +**OS System**: +**manim version**: master +**python version**: From f4c82b62afb39709c1247b6be310794980810057 Mon Sep 17 00:00:00 2001 From: Tony031218 <975062472@qq.com> Date: Tue, 2 Feb 2021 16:39:02 +0800 Subject: [PATCH 4/7] create config.yml and delete old template --- .github/ISSUE_TEMPLATE.md | 14 -------------- .github/ISSUE_TEMPLATE/config.yml | 5 +++++ 2 files changed, 5 insertions(+), 14 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE.md create mode 100644 .github/ISSUE_TEMPLATE/config.yml diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md deleted file mode 100644 index d83c3d2d..00000000 --- a/.github/ISSUE_TEMPLATE.md +++ /dev/null @@ -1,14 +0,0 @@ -### If this is a support request: - -**Please attempt to solve the problem on your own before opening an issue.** -Between old issues, StackOverflow, and Google, you should be able to find -solutions to most of the common problems. - -Include at least: -1. Steps to reproduce the issue (e.g. the command you ran) -2. The unexpected behavior that occurred (e.g. error messages or screenshots) -3. The environment (e.g. operating system and version of manim) - - -### If this is a feature request: -Include the motivation for making this change. diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 00000000..5581a02a --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1,5 @@ +blank_issues_enabled: true +contact_links: + - name: Ask A Question + url: https://github.com/3b1b/manim/discussions/categories/q-a + about: Please ask questions you encountered here. \ No newline at end of file From 2d19ee82642c9f435ddf992abbf97ff1619d579c Mon Sep 17 00:00:00 2001 From: Tony031218 <975062472@qq.com> Date: Tue, 2 Feb 2021 16:45:57 +0800 Subject: [PATCH 5/7] update PULL_REQUEST_TEMPLATE --- .github/PULL_REQUEST_TEMPLATE.md | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index cd810c78..3ca8f474 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,9 +1,18 @@ -Thanks for contributing to manim! + -**Please ensure that your pull request works with the latest version of manim.** -You should also include: +## Motivation + -1. The motivation for making this change (or link the relevant issues) -2. How you tested the new behavior (e.g. a minimal working example, before/after -screenshots, gifs, commands, etc.) This is rather informal at the moment, but -the goal is to show us how you know the pull request works as intended. +## Proposed changes + +- +- +- + +## Test + +**Code**: + +**Result**: \ No newline at end of file From c32104b7caa0443e2e2b33922a8a6495fdbdef5b Mon Sep 17 00:00:00 2001 From: Tony031218 <975062472@qq.com> Date: Tue, 2 Feb 2021 16:53:08 +0800 Subject: [PATCH 6/7] revert changes which is in #1329 --- manimlib/shaders/quadratic_bezier_fill/frag.glsl | 2 +- manimlib/shaders/quadratic_bezier_stroke/geom.glsl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/manimlib/shaders/quadratic_bezier_fill/frag.glsl b/manimlib/shaders/quadratic_bezier_fill/frag.glsl index b2a1c82a..c16c167e 100644 --- a/manimlib/shaders/quadratic_bezier_fill/frag.glsl +++ b/manimlib/shaders/quadratic_bezier_fill/frag.glsl @@ -51,7 +51,7 @@ float sdf(){ float sgn = orientation * sign(v2); float Fp = (p.x * p.x - p.y); if(sgn * Fp < 0){ - return 0.0; + return 0; }else{ return min_dist_to_curve(uv_coords, uv_b2, bezier_degree); } diff --git a/manimlib/shaders/quadratic_bezier_stroke/geom.glsl b/manimlib/shaders/quadratic_bezier_stroke/geom.glsl index f9cfe303..b878e295 100644 --- a/manimlib/shaders/quadratic_bezier_stroke/geom.glsl +++ b/manimlib/shaders/quadratic_bezier_stroke/geom.glsl @@ -66,7 +66,7 @@ void flatten_points(in vec3[3] points, out vec2[3] flat_points){ float angle_between_vectors(vec2 v1, vec2 v2){ float v1_norm = length(v1); float v2_norm = length(v2); - if(v1_norm == 0 || v2_norm == 0) return 0.0; + if(v1_norm == 0 || v2_norm == 0) return 0; float dp = dot(v1, v2) / (v1_norm * v2_norm); float angle = acos(clamp(dp, -1.0, 1.0)); float sn = sign(cross2d(v1, v2)); From 143634742bda552aae41495a569c49df083a3177 Mon Sep 17 00:00:00 2001 From: Tony031218 <975062472@qq.com> Date: Tue, 2 Feb 2021 16:56:41 +0800 Subject: [PATCH 7/7] revert changes which is in #1329 --- manimlib/shaders/quadratic_bezier_stroke/geom.glsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manimlib/shaders/quadratic_bezier_stroke/geom.glsl b/manimlib/shaders/quadratic_bezier_stroke/geom.glsl index b878e295..ffb4e8eb 100644 --- a/manimlib/shaders/quadratic_bezier_stroke/geom.glsl +++ b/manimlib/shaders/quadratic_bezier_stroke/geom.glsl @@ -269,4 +269,4 @@ void main() { EmitVertex(); } EndPrimitive(); -} +} \ No newline at end of file