From d98d1ec6104243986441a0290705faf5204e21e8 Mon Sep 17 00:00:00 2001 From: Grant Sanderson Date: Mon, 7 Jan 2019 13:24:16 -0800 Subject: [PATCH] Changed default behavior to have no finishing sound, and instead of passing in --no-sound to prevent the sound, one would pass in --sound to activate it --- manimlib/config.py | 6 +++--- manimlib/extract_scene.py | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/manimlib/config.py b/manimlib/config.py index cdae8d8e..a5d78f0d 100644 --- a/manimlib/config.py +++ b/manimlib/config.py @@ -41,9 +41,9 @@ def parse_cli(): parser.add_argument("-r", "--resolution") parser.add_argument("-c", "--color") parser.add_argument( - "--no_sound", + "--sound", action="store_true", - help="Don't play a success/failure sound", + help="Play a success/failure sound", ) module_location.add_argument( "--livestream", @@ -128,7 +128,7 @@ def get_configuration(args): "output_name": output_name, "start_at_animation_number": args.start_at_animation_number, "end_at_animation_number": None, - "no_sound": args.no_sound, + "sound": args.sound, } # Camera configuration diff --git a/manimlib/extract_scene.py b/manimlib/extract_scene.py index d707be4d..6885d869 100644 --- a/manimlib/extract_scene.py +++ b/manimlib/extract_scene.py @@ -136,14 +136,14 @@ def main(config): for SceneClass in get_scene_classes(scene_names_to_classes, config): try: handle_scene(SceneClass(**scene_kwargs), **config) - if not config["no_sound"]: + if config["sound"]: play_finish_sound() sys.exit(0) except Exception: print("\n\n") traceback.print_exc() print("\n\n") - if not config["no_sound"]: + if config["sound"]: play_error_sound() sys.exit(2)