From 32abbb9371308e8dff7410de387fe78e64b6fe7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20V=C3=A1zquez?= Date: Tue, 20 Aug 2019 01:34:13 -0500 Subject: [PATCH 1/2] Change way to remove sound_file_path --- manimlib/scene/scene_file_writer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manimlib/scene/scene_file_writer.py b/manimlib/scene/scene_file_writer.py index 46875e83..d52f5baa 100644 --- a/manimlib/scene/scene_file_writer.py +++ b/manimlib/scene/scene_file_writer.py @@ -351,7 +351,7 @@ class SceneFileWriter(object): ] subprocess.call(commands) shutil.move(temp_file_path, movie_file_path) - subprocess.call(["rm", sound_file_path]) + os.remove(sound_file_path) self.print_file_ready_message(movie_file_path) From a19a6317ec187f65efb0c8f46bc613b4a978d22a Mon Sep 17 00:00:00 2001 From: Hlaing Min Date: Fri, 13 Sep 2019 01:51:22 +0800 Subject: [PATCH 2/2] Closes: #720 Fix to interpret subsequent points of absolute MoveTo (M) command as absolute LineTo (L). --- manimlib/mobject/svg/svg_mobject.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/manimlib/mobject/svg/svg_mobject.py b/manimlib/mobject/svg/svg_mobject.py index 4798003a..56f3ef69 100644 --- a/manimlib/mobject/svg/svg_mobject.py +++ b/manimlib/mobject/svg/svg_mobject.py @@ -298,7 +298,7 @@ class SVGMobject(VMobject): if not isinstance(element, minidom.Element): return if element.hasAttribute('id'): - return element + return [element] for e in element.childNodes: all_childNodes_have_id.append(self.get_all_childNodes_have_id(e)) return self.flatten([e for e in all_childNodes_have_id if e]) @@ -371,11 +371,11 @@ class VMobjectFromSVGPathstring(VMobject): new_points = new_points[1:] command = "L" - # Treat everything as relative line-to until empty for p in new_points: - # Treat as relative - p[0] += self.points[-1, 0] - p[1] += self.points[-1, 1] + if isLower: + # Treat everything as relative line-to until empty + p[0] += self.points[-1, 0] + p[1] += self.points[-1, 1] self.add_line_to(p) return