From b0b71910a5046a9d2d307d8630bf815d7985c6fb Mon Sep 17 00:00:00 2001 From: Grant Sanderson Date: Fri, 14 Feb 2020 10:53:52 -0800 Subject: [PATCH] Couple notes on the problems with Mobject.show --- manimlib/mobject/mobject.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/manimlib/mobject/mobject.py b/manimlib/mobject/mobject.py index f43078e7..342dd525 100644 --- a/manimlib/mobject/mobject.py +++ b/manimlib/mobject/mobject.py @@ -41,6 +41,7 @@ class Mobject(Container): "frag_shader_file": "", "render_primative": moderngl.TRIANGLE_STRIP, "texture_path": "", + # Must match in attributes of vert shader "shader_dtype": [ ('point', np.float32, (3,)), ] @@ -111,14 +112,13 @@ class Mobject(Container): # Displaying def get_image(self, camera=None): - if camera is None: - from manimlib.camera.camera import Camera - camera = Camera() + # TODO, this doesn't...you know, seem to actually work + camera.clear() camera.capture(self) return camera.get_image() - def show(self, camera=None): - self.get_image(camera=camera).show() + def show(self, camera): + self.get_image(camera).show() def save_image(self, name=None): self.get_image().save(