public-mirrors/3b1b-manim
1
0
Fork 0
mirror of https://github.com/3b1b/manim.git synced 2025-08-05 16:49:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Bug fix and PEP8 on svg_mobject.py

Browse source
This commit is contained in:
Grant Sanderson 2018-04-12 21:56:28 -07:00
parent 515257e0b1
commit a9b76ebcfa
1 changed files with 14 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
mobject/svg/svg_mobject.py
View file

@ -165,7 +165,7 @@ class SVGMobject(VMobject):
# input preprocessing # input preprocessing
if fill_color in ["", "none", "#FFF", "#FFFFFF"] or Color(fill_color) == Color(WHITE): if fill_color in ["", "none", "#FFF", "#FFFFFF"] or Color(fill_color) == Color(WHITE):
opacity = 0 opacity = 0
fill_color = BLACK # shdn't be necessary but avoids error msgs fill_color = BLACK # shdn't be necessary but avoids error msgs
if fill_color in ["#000", "#000000"]: if fill_color in ["#000", "#000000"]:
fill_color = WHITE fill_color = WHITE
if stroke_color in ["", "none", "#FFF", "#FFFFFF"] or Color(stroke_color) == Color(WHITE): if stroke_color in ["", "none", "#FFF", "#FFFFFF"] or Color(stroke_color) == Color(WHITE):
@ -175,10 +175,6 @@ class SVGMobject(VMobject):
stroke_color = WHITE stroke_color = WHITE
if stroke_width in ["", "none", "0"]: if stroke_width in ["", "none", "0"]:
stroke_width = 0 stroke_width = 0
# is there sth to draw?
if opacity == 0 and stroke_width == 0:
return
if corner_radius in ["", "0", "none"]: if corner_radius in ["", "0", "none"]:
corner_radius = 0 corner_radius = 0
@ -187,22 +183,22 @@ class SVGMobject(VMobject):
if corner_radius == 0: if corner_radius == 0:
mob = Rectangle( mob = Rectangle(
width = float(rect_element.getAttribute("width")), width=float(rect_element.getAttribute("width")),
height = float(rect_element.getAttribute("height")), height=float(rect_element.getAttribute("height")),
stroke_width = stroke_width, stroke_width=stroke_width,
stroke_color = stroke_color, stroke_color=stroke_color,
fill_color = fill_color, fill_color=fill_color,
fill_opacity = opacity fill_opacity=opacity
) )
else: else:
mob = RoundedRectangle( mob = RoundedRectangle(
width = float(rect_element.getAttribute("width")), width=float(rect_element.getAttribute("width")),
height = float(rect_element.getAttribute("height")), height=float(rect_element.getAttribute("height")),
stroke_width = stroke_width, stroke_width=stroke_width,
stroke_color = stroke_color, stroke_color=stroke_color,
fill_color = fill_color, fill_color=fill_color,
fill_opacity = opacity, fill_opacity=opacity,
corner_radius = corner_radius corner_radius=corner_radius
) )
mob.shift(mob.get_center() - mob.get_corner(UP + LEFT)) mob.shift(mob.get_center() - mob.get_corner(UP + LEFT))