public-mirrors/3b1b-manim
1
0
Fork 0
mirror of https://github.com/3b1b/manim.git synced 2025-08-05 16:49:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor: move type validation to top of Animation.__init__ and extract into method (#2332)

Browse source
This commit is contained in:
Irvanal Haq 2025-06-10 22:11:16 +07:00 • committed by GitHub
parent 8b9ae95703
commit 53bc83d94a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
manimlib/animation/animation.py
View file

@ -33,7 +33,7 @@ class Animation(object):
lag_ratio: float = DEFAULT_ANIMATION_LAG_RATIO,
rate_func: Callable[[float], float] = smooth,
name: str = "",
# Does this animation add or remove a mobject form the screen
# Does this animation add or remove a mobject from the screen
remover: bool = False,
# What to enter into the update function upon completion
final_alpha_value: float = 1.0,
@ -42,6 +42,7 @@ class Animation(object):
# updating, call mobject.suspend_updating() before the animation
suspend_mobject_updating: bool = False,
):
self._validate_input_type(mobject)
self.mobject = mobject
self.run_time = run_time
self.time_span = time_span
@ -52,7 +53,9 @@ class Animation(object):
self.lag_ratio = lag_ratio
self.suspend_mobject_updating = suspend_mobject_updating
assert isinstance(mobject, Mobject)
def _validate_input_type(self, mobject: Mobject) -> None:
if not isinstance(mobject, Mobject):
raise TypeError("Animation only works for Mobjects.")
def __str__(self) -> str:
return self.name