public-mirrors/3b1b-manim
1
0
Fork 0
mirror of https://github.com/3b1b/manim.git synced 2025-08-05 16:49:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix Ellipse constructor: 'width' is not defined

Browse source 
Constructing an ellipse before gave the error "name 'width' is not defined"

I got this error when running the tutorial at https://github.com/zimmermant/manim_tutorial/blob/master/manim_tutorial_P37.py.

python3 -m manim manim_tutorial_P37.py MoreShapes -pl

Traceback (most recent call last):
  File "/Users/jeanwhitmore/Code/python3/manim/manimlib/extract_scene.py", line 153, in main
    scene = SceneClass(**scene_kwargs)
  File "/Users/jeanwhitmore/Code/python3/manim/manimlib/scene/scene.py", line 52, in __init__
    self.construct()
  File "manim_tutorial_P37.py", line 33, in construct
    ellipse=Ellipse(width=3, height=1, color=RED)
  File "/Users/jeanwhitmore/Code/python3/manim/manimlib/mobject/geometry.py", line 319, in __init__
    self.set_width(width, stretch=True)
NameError: name 'width' is not defined

After this fix, the Ellipse can be constructed and the animation is generated.

(Another shape is still broken, and I will try to fix that, too.)
This commit is contained in:
jeanimal 2019-02-17 21:34:40 -06:00 • committed by GitHub
parent b2ad5e2173
commit 2d552e0aa4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
manimlib/mobject/geometry.py
View file

@ -316,8 +316,8 @@ class Ellipse(Circle):
def __init__(self, **kwargs):
Circle.__init__(self, **kwargs)
self.set_width(width, stretch=True)
self.set_height(width, stretch=True)
self.set_width(self.width, stretch=True)
self.set_height(self.width, stretch=True)
class AnnularSector(Arc):